Display deployment status for cf app command [v8]

.github/ops-files/replace-redis.yml

@@ -0,0 +1,6 @@
+---
+- type: replace
+  path: /instance_groups/name=api/jobs/name=redis?
+  value: 
+    name: valkey
+    release: capi

.github/workflows/tests-integration-reusable.yml

@@ -179,6 +179,7 @@ jobs:
         bosh -d cf manifest > /tmp/manifest.yml
         bosh interpolate /tmp/manifest.yml \
           -o .github/ops-files/use-cflinuxfs3.yml \
+          -o .github/ops-files/replace-redis.yml \
           -o cf-deployment/operations/use-internal-lookup-for-route-services.yml \
           -o cf-deployment/operations/add-persistent-isolation-segment-diego-cell.yml \
           -o cli-ci/ci/infrastructure/operations/use-latest-capi.yml \

actor/v7action/application_summary.go

@@ -18,6 +18,7 @@ type ApplicationSummary struct {
 type DetailedApplicationSummary struct {
 	ApplicationSummary
 	CurrentDroplet resources.Droplet
+	Deployment     resources.Deployment
 }
 
 func (a ApplicationSummary) GetIsolationSegmentName() (string, bool) {
@@ -120,6 +121,12 @@ func (actor Actor) GetDetailedAppSummary(appName, spaceGUID string, withObfuscat
 		return DetailedApplicationSummary{}, allWarnings, err
 	}
 
+	detailedSummary, warnings, err = actor.addDeployment(detailedSummary)
+	allWarnings = append(allWarnings, warnings...)
+	if err != nil {
+		return DetailedApplicationSummary{}, allWarnings, err
+	}
+
 	return detailedSummary, allWarnings, err
 }
 
@@ -206,6 +213,21 @@ func (actor Actor) addDroplet(summary ApplicationSummary) (DetailedApplicationSu
 	}, allWarnings, nil
 }
 
+func (actor Actor) addDeployment(detailedSummary DetailedApplicationSummary) (DetailedApplicationSummary, Warnings, error) {
+	var allWarnings Warnings
+
+	deployment, warnings, err := actor.GetLatestActiveDeploymentForApp(detailedSummary.GUID)
+	allWarnings = append(allWarnings, warnings...)
+	if err != nil {
+		if _, ok := err.(actionerror.ActiveDeploymentNotFoundError); !ok {
+			return DetailedApplicationSummary{}, allWarnings, err
+		}
+	}
+
+	detailedSummary.Deployment = deployment
+	return detailedSummary, allWarnings, nil
+}
+
 func toAppGUIDs(apps []resources.Application) []string {
 	guids := make([]string, len(apps))
 

actor/v7action/application_summary_test.go

@@ -4,7 +4,6 @@ import (
 	"errors"
 	"fmt"
 
-	"code.cloudfoundry.org/cli/actor/v7action"
 	. "code.cloudfoundry.org/cli/actor/v7action"
 	"code.cloudfoundry.org/cli/actor/v7action/v7actionfakes"
 	"code.cloudfoundry.org/cli/api/cloudcontroller/ccerror"
@@ -574,6 +573,115 @@ var _ = Describe("Application Summary Actions", func() {
 						)
 					})
 
+					When("getting application deployment succeeds", func() {
+						When("the deployment is active", func() {
+							When("the deployment strategy is rolling", func() {
+								When("the deployment is in progress", func() {
+									BeforeEach(func() {
+										fakeCloudControllerClient.GetDeploymentsReturns(
+											[]resources.Deployment{
+												{
+													GUID:         "some-deployment-guid",
+													Strategy:     "rolling",
+													StatusValue:  "ACTIVE",
+													StatusReason: "DEPLOYING",
+												},
+											},
+											nil,
+											nil,
+										)
+									})
+									It("returns the deployment information", func() {
+										Expect(summary.Deployment).To(Equal(resources.Deployment{
+											GUID:         "some-deployment-guid",
+											Strategy:     "rolling",
+											StatusValue:  "ACTIVE",
+											StatusReason: "DEPLOYING",
+										}))
+									})
+								})
+
+								When("the deployment is canceled", func() {
+									When("the deployment is in progress", func() {
+										BeforeEach(func() {
+											fakeCloudControllerClient.GetDeploymentsReturns(
+												[]resources.Deployment{
+													{
+														GUID:         "some-deployment-guid",
+														Strategy:     "rolling",
+														StatusValue:  "ACTIVE",
+														StatusReason: "CANCELLING",
+													},
+												},
+												nil,
+												nil,
+											)
+										})
+										It("returns the deployment information", func() {
+											Expect(summary.Deployment).To(Equal(resources.Deployment{
+												GUID:         "some-deployment-guid",
+												Strategy:     "rolling",
+												StatusValue:  "ACTIVE",
+												StatusReason: "CANCELLING",
+											}))
+										})
+									})
+								})
+							})
+						})
+
+						When("the deployment is finalized", func() {
+							BeforeEach(func() {
+								fakeCloudControllerClient.GetDeploymentsReturns(
+									[]resources.Deployment{
+										{
+											GUID:         "",
+											Strategy:     "",
+											StatusValue:  "",
+											StatusReason: "",
+										},
+									},
+									nil,
+									nil,
+								)
+							})
+							It("returns no deployment information", func() {
+								Expect(summary.Deployment).To(Equal(resources.Deployment{
+									GUID:         "",
+									Strategy:     "",
+									StatusValue:  "",
+									StatusReason: "",
+								}))
+							})
+						})
+					})
+
+					When("getting application deployment fails", func() {
+						BeforeEach(func() {
+							fakeCloudControllerClient.GetDeploymentsReturns(
+								nil,
+								ccv3.Warnings{"get-deployments-warning"},
+								errors.New("some-error"),
+							)
+						})
+
+						It("returns the warnings and error", func() {
+							Expect(executeErr).To(MatchError("some-error"))
+							Expect(warnings).To(ConsistOf(
+								"get-apps-warning",
+								"get-app-processes-warning",
+								"get-process-by-type-warning",
+								"get-process-sidecars-warning",
+								"get-process-instances-warning",
+								"get-process-by-type-warning",
+								"get-process-sidecars-warning",
+								"get-process-instances-warning",
+								"get-app-droplet-warning",
+								"get-deployments-warning",
+							))
+						})
+					})
+
 					When("getting application routes succeeds", func() {
 						BeforeEach(func() {
 							fakeCloudControllerClient.GetApplicationRoutesReturns(
@@ -589,7 +697,7 @@ var _ = Describe("Application Summary Actions", func() {
 						It("returns the summary and warnings with droplet information", func() {
 							Expect(executeErr).ToNot(HaveOccurred())
 							Expect(summary).To(Equal(DetailedApplicationSummary{
-								ApplicationSummary: v7action.ApplicationSummary{
+								ApplicationSummary: ApplicationSummary{
 									Application: resources.Application{
 										Name:  "some-app-name",
 										GUID:  "some-app-guid",
@@ -733,7 +841,7 @@ var _ = Describe("Application Summary Actions", func() {
 					It("returns the summary and warnings without droplet information", func() {
 						Expect(executeErr).ToNot(HaveOccurred())
 						Expect(summary).To(Equal(DetailedApplicationSummary{
-							ApplicationSummary: v7action.ApplicationSummary{
+							ApplicationSummary: ApplicationSummary{
 								Application: resources.Application{
 									Name:  "some-app-name",
 									GUID:  "some-app-guid",

api/cloudcontroller/ccv3/constant/deployment.go

@@ -28,6 +28,12 @@ const (
 type DeploymentStatusReason string
 
 const (
+	// DeploymentStatusReasonDeploying means the deployment is in state 'DEPLOYING'
+	DeploymentStatusReasonDeploying DeploymentStatusReason = "DEPLOYING"
+
+	// DeploymentCanceling means the deployment is in state 'CANCELING'
+	DeploymentStatusReasonCanceling DeploymentStatusReason = "CANCELING"
+
 	// DeploymentStatusReasonDeployed means the deployment's status.value is
 	// 'DEPLOYED'
 	DeploymentStatusReasonDeployed DeploymentStatusReason = "DEPLOYED"

command/v7/shared/app_summary_displayer.go

@@ -13,6 +13,8 @@ import (
 	"code.cloudfoundry.org/cli/types"
 	"code.cloudfoundry.org/cli/util/ui"
 	log "github.com/sirupsen/logrus"
+	"golang.org/x/text/cases"
+	"golang.org/x/text/language"
 )
 
 type AppSummaryDisplayer struct {
@@ -159,6 +161,12 @@ func (display AppSummaryDisplayer) displayProcessTable(summary v7action.Detailed
 		}
 		display.displayAppInstancesTable(process)
 	}
+
+	if summary.Deployment.StatusValue == constant.DeploymentStatusValueActive {
+		display.UI.DisplayText(fmt.Sprintf("%s deployment currently %s",
+			cases.Title(language.English, cases.NoLower).String(string(summary.Deployment.Strategy)),
+			summary.Deployment.StatusReason))
+	}
 }
 
 func (display AppSummaryDisplayer) getCreatedTime(summary v7action.DetailedApplicationSummary) string {

command/v7/shared/app_summary_displayer_test.go

@@ -1,6 +1,7 @@
 package shared_test
 
 import (
+	"fmt"
 	"time"
 
 	"code.cloudfoundry.org/cli/actor/v7action"
@@ -13,6 +14,8 @@ import (
 	. "github.com/onsi/ginkgo/v2"
 	. "github.com/onsi/gomega"
 	. "github.com/onsi/gomega/gbytes"
+	"golang.org/x/text/cases"
+	"golang.org/x/text/language"
 )
 
 var _ = Describe("app summary displayer", func() {
@@ -652,5 +655,59 @@ var _ = Describe("app summary displayer", func() {
 				Expect(testUI.Out).To(Say(`some-buildpack`))
 			})
 		})
+
+		When("there is an active deployment", func() {
+			When("the deployment strategy is rolling", func() {
+				When("the deployment is in progress", func() {
+					BeforeEach(func() {
+						summary = v7action.DetailedApplicationSummary{
+							Deployment: resources.Deployment{
+								Strategy:     constant.DeploymentStrategyRolling,
+								StatusValue:  constant.DeploymentStatusValueActive,
+								StatusReason: constant.DeploymentStatusReasonDeploying,
+							},
+						}
+					})
+
+					It("displays the message", func() {
+						Expect(testUI.Out).To(Say("Rolling deployment currently DEPLOYING"))
+					})
+				})
+
+				When("the deployment is cancelled", func() {
+					BeforeEach(func() {
+						summary = v7action.DetailedApplicationSummary{
+							Deployment: resources.Deployment{
+								Strategy:     constant.DeploymentStrategyRolling,
+								StatusValue:  constant.DeploymentStatusValueActive,
+								StatusReason: constant.DeploymentStatusReasonCanceling,
+							},
+						}
+					})
+
+					It("displays the message", func() {
+						Expect(testUI.Out).To(Say("Rolling deployment currently CANCELING"))
+					})
+				})
+			})
+		})
+
+		When("there is no active deployment", func() {
+			BeforeEach(func() {
+				summary = v7action.DetailedApplicationSummary{
+					Deployment: resources.Deployment{
+						Strategy:     "",
+						StatusValue:  "",
+						StatusReason: "",
+					},
+				}
+			})
+
+			It("does not display deployment info", func() {
+				Expect(testUI.Out).NotTo(Say(fmt.Sprintf("%s deployment currently %s",
+					cases.Title(language.English, cases.NoLower).String(string(summary.Deployment.Strategy)),
+					summary.Deployment.StatusReason)))
+			})
+		})
 	})
 })

integration/v7/isolated/app_command_test.go

@@ -5,6 +5,7 @@ import (
 	"os"
 	"path"
 	"path/filepath"
+	"time"
 
 	. "code.cloudfoundry.org/cli/cf/util/testhelpers/matchers"
 	"code.cloudfoundry.org/cli/integration/helpers"
@@ -253,6 +254,53 @@ applications:
 					Eventually(session).Should(Exit(0))
 				})
 			})
+
+			When("there is an active deployment", func() {
+				BeforeEach(func() {
+					helpers.WithHelloWorldApp(func(appDir string) {
+						Eventually(helpers.CF("push", appName, "-p", appDir, "-b", "staticfile_buildpack")).Should(Exit(0))
+					})
+				})
+
+				When("the deployment strategy is rolling", func() {
+					When("the deployment is in progress", func() {
+						It("displays the message", func() {
+							session := helpers.CF("restart", appName, "--strategy", "rolling")
+
+							session1 := helpers.CF("app", appName)
+							Eventually(session1).Should(Say("Rolling deployment currently DEPLOYING"))
+							Eventually(session).Should(Exit(0))
+							Eventually(session1).Should(Exit(0))
+						})
+					})
+					When("the deployment is cancelled", func() {
+						It("displays the message", func() {
+							helpers.CF("restart", appName, "--strategy", "rolling")
+							time.Sleep(3 * time.Second)
+							session1 := helpers.CF("cancel-deployment", appName)
+							Eventually(session1).Should(Exit(0))
+
+							session2 := helpers.CF("app", appName)
+							Eventually(session2).Should(Say("Rolling deployment currently CANCELING"))
+							Eventually(session2).Should(Exit(0))
+						})
+					})
+				})
+			})
+
+			When("there is no active deployment", func() {
+				BeforeEach(func() {
+					helpers.WithHelloWorldApp(func(appDir string) {
+						Eventually(helpers.CF("push", appName, "-p", appDir, "-b", "staticfile_buildpack")).Should(Exit(0))
+					})
+				})
+
+				It("doesn not display the message", func() {
+					session := helpers.CF("app", appName)
+					Eventually(session).Should(Exit(0))
+					Eventually(session).ShouldNot(Say(`\w+ deployment currently \w+`))
+				})
+			})
 		})
 
 		Describe("version independent display", func() {