Install ginkgo "out of the box" #2920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change installs the version of Ginkgo specified in go.mod, modifies the Makefile to do this before each flavor of test, and simplifies the CI tasks that invoke these tests. Prior to this change, the Makefile assumes the presence of a system-level installation of Ginkgo. That installation of Ginkgo will not necessarily match the version specified in our go.mod. This introduces the (slight) possibility of subtle differences in the behavior of the test library. It also complicates spinning up a new environment, either for a developer or in CI.
Samze
reviewed
May 14, 2024
These matchers are imported as needed in the test files that need them. There is no need to install them as a system-level dependency, so let's not.
moleske
approved these changes
May 15, 2024
This was referenced May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This change installs the version of Ginkgo specified in
go.mod, modifies theMakefileto do this before each flavor of test, and simplifies the CI tasks that invoke these tests.Why Is This PR Valuable?
Prior to this change, the
Makefileassumes the presence of a system-level installation of Ginkgo. That installation of Ginkgo will not necessarily match the version specified in ourgo.mod.This introduces the (slight) possibility of subtle differences in the behavior of the test library. It also complicates spinning up a new environment, either for a developer or in CI.
Applicable Issues
n/a
How Urgent Is The Change?
Not urgent.
Related PRs
v7branchv8branch