-
Notifications
You must be signed in to change notification settings - Fork 933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix invalid usage of create-space #287
Conversation
Hey liuhewei! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you've already signed the CLA. |
We have created an issue in Pivotal Tracker to manage this. You can view the current status of your issue at: https://www.pivotaltracker.com/story/show/82013594. |
Hi @gregoehmen |
yes. I have a story for all other instances of this issue & it is fairly high in the backlog https://www.pivotaltracker.com/story/show/82448794 |
@goehmen It's good to know that cli team also noticed this. Do you want us to fix them or you guys are working on it? |
If you want to submit a pull request, I'll take it. We won't get to our Greg On Tue, Nov 18, 2014 at 5:12 PM, Hewei Liu notifications@github.com wrote:
|
@goehmen OK, we'll fix them and update this PR. Updated: Here is the commands affected: |
Before Fix: If cf user does 'cf create-space my-space blahablaha' then its success After Fix:If cf user does 'cf create-space my-space blahablaha' then it will fail with proper reason
'cf create-space SPACE blahblah' 'cf orgs blhablah' 'cf spaces blahblah' 'cf update-service SERVICE blahblah' 'cf marketplace blahblah' 'cf delete-service SERVICE_INSTANCE blahblah' 'cf services blahblah' 'cf plugins blahblah' 'cf feature-flags blahblah' 'cf create-space my-space blahablaha' 'cf app APPNAME blahablaha' 'cf delete APPNAME blahblah' 'cf service-access blahblah' 'cf service-auth-tokens blahblah' 'cf service-brokers blahblah' 'cf delete-orphaned-routes' 'cf apps blahblah' 'cf restart APP blahblah' 'cf buildpacks blahblah' 'cf running-environment-variable-group blahblah' 'cf staging-environment-variable-group blahblah' 'cf space-quotas blahblah' 'cf quotas blahblah' 'cf routes blahblah' 'cf start APP blahblah' for example Before Fix: If cf user does 'cf orgs blahblah' the command is success but ignord the second argument After Fix:If cf user does 'cf orgs blahblah' the command will with proper reason
Extraneous arguments now cause commands to fail with usage.
Keep the behavior of "create-space" the same as "create-org", which means always prompt error if the input parameters are more than one.
Before Fix: If cf user does
'cf create-space my-space blahablaha'
then its success
After Fix:If cf user does
'cf create-space my-space blahablaha'
then it will fail with proper reason