Improve cf apps with --no-stats and better error handling
#2795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cf apps with --no-stats and better error handling
Fetching process stats requires a `/stats` request for each process. If a space contains a large number apps or processes this slows down `cf apps`. In case a user is not interested in stats the `--no-stats` flag can be helpful.
As a user calls `cf apps` in a large space it might happen that a app was deleted while the CLI is putting all the different information (processes, stats & routes) together. This leads to a failing `cf apps` command. This change prevents this by catching `ProcessNotFoundError` errors and returning `nil` instead. Related to cloudfoundry#2734
a-b
approved these changes
Feb 22, 2024
|
Thank you @johha for your contribution. We appreciate the quality of your commit and PR description. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where this PR should be backported?
cf appswith--no-statsand better error handling [V8] #2796Description of the Change
Introduce
--no-statsforcf appsFetching process stats requires a
/statsrequest for each process.If a space contains a large number apps or processes this slows down
cf apps.In case a user is not interested in stats the
--no-statsflag can be helpful.Handle
ProcessNotFoundErrorincf appsAs a user calls
cf appsin a large space it might happen that a appwas deleted while the CLI is putting all the different information (processes, stats & routes) together.
This leads to a failing
cf appscommand.This change prevents this by catching
ProcessNotFoundErrorerrors and returningnilinstead.Related to #2734