Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure response body is always closed in CloudControllerConnection (v8) #2425

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

chitoku-k
Copy link
Contributor

Does this PR modify CLI v6, CLI v7, or CLI v8?

CLI v8

Description of the Change

#2423 for v8 branch.

@chitoku-k chitoku-k changed the title Ensure response body is always closed in CloudControllerConnection Ensure response body is always closed in CloudControllerConnection (v8) May 18, 2023
Copy link
Member

@a-b a-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@a-b a-b force-pushed the v8 branch 2 times, most recently from d7280b3 to eb80409 Compare June 9, 2023 10:45
@a-b a-b force-pushed the fix/close-response-body-v8 branch 2 times, most recently from ab030ac to fa50a68 Compare June 15, 2023 14:08
@a-b a-b force-pushed the fix/close-response-body-v8 branch from fa50a68 to c1ed256 Compare July 13, 2023 21:04
@chitoku-k chitoku-k force-pushed the fix/close-response-body-v8 branch from c1ed256 to 027cd27 Compare January 10, 2024 02:26
@moleske moleske merged commit a359195 into cloudfoundry:v8 Jan 18, 2024
13 checks passed
@chitoku-k chitoku-k deleted the fix/close-response-body-v8 branch January 19, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants