Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ruby web fixture app #2420

Merged
merged 2 commits into from
May 15, 2023
Merged

Fix ruby web fixture app #2420

merged 2 commits into from
May 15, 2023

Conversation

a-b
Copy link
Member

@a-b a-b commented May 13, 2023

Does this PR modify CLI v6, CLI v7, or CLI v8?

  • main
  • v8
  • v7

Description of the Change

Fixing ruby web application used for integration testing

Why Is This PR Valuable?

Green tests

How Urgent Is The Change?

yes

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 13, 2023 •
edited
Loading

CLA Missing ID CLA Not Signed

@a-b a-b closed this May 13, 2023
@a-b a-b reopened this May 13, 2023
Benjamintf1
Benjamintf1 approved these changes May 15, 2023
View reviewed changes
Copy link
Member

@Benjamintf1 Benjamintf1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@a-b a-b merged commit 54a68f5 into main May 15, 2023
@a-b a-b deleted the update-ruby-version-in-fixtures branch May 15, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Benjamintf1 Benjamintf1 Benjamintf1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@a-b @Benjamintf1 @cf-gitbot