feat: --update-if-exists flag for create-service-broker (main) #2402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gururajsh
approved these changes
Apr 20, 2023
A very common pattern is to have scripting like: ``` cf create-service-broker $SERVICE_BROKER_NAME $USERNAME $PASSWORD $APP_URL || cf update-service-broker $SERVICE_BROKER_NAME $USERNAME $PASSWORD $APP_URL ``` This is not ideal because: - it's a duplicated pattern that the CF CLI could handle better - it does not check the error type - it results in a failure being logged, when in fact there was none Adding a --update-if-exists flag to the CF CLI allows the following alternative: ``` cf create-service-broker $SERVICE_BROKER_NAME $USERNAME $PASSWORD $APP_URL --update-if-exists ```
blgm
added a commit
to blgm/cli
that referenced
this pull request
Apr 24, 2023
…#2402) A very common pattern is to have scripting like: ``` cf create-service-broker $SERVICE_BROKER_NAME $USERNAME $PASSWORD $APP_URL || cf update-service-broker $SERVICE_BROKER_NAME $USERNAME $PASSWORD $APP_URL ``` This is not ideal because: - it's a duplicated pattern that the CF CLI could handle better - it does not check the error type - it results in a failure being logged, when in fact there was none Adding a --update-if-exists flag to the CF CLI allows the following alternative: ``` cf create-service-broker $SERVICE_BROKER_NAME $USERNAME $PASSWORD $APP_URL --update-if-exists ```
gururajsh
pushed a commit
that referenced
this pull request
Apr 24, 2023
A very common pattern is to have scripting like: ``` cf create-service-broker $SERVICE_BROKER_NAME $USERNAME $PASSWORD $APP_URL || cf update-service-broker $SERVICE_BROKER_NAME $USERNAME $PASSWORD $APP_URL ``` This is not ideal because: - it's a duplicated pattern that the CF CLI could handle better - it does not check the error type - it results in a failure being logged, when in fact there was none Adding a --update-if-exists flag to the CF CLI allows the following alternative: ``` cf create-service-broker $SERVICE_BROKER_NAME $USERNAME $PASSWORD $APP_URL --update-if-exists ```
This was referenced Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR modify CLI v6, CLI v7, or CLI v8?
Description of the Change
A very common pattern is to have scripting like:
This is not ideal because:
Adding a --update-if-exists flag to the CF CLI allows the following
alternative:
Why Is This PR Valuable?
It gives script users a better and safer experience using the CF CLI
Why Should This Be In Core?
It's a change to a core command
Applicable Issues
None
How Urgent Is The Change?
It's likely that a lot of create-broker scripts will need to be updated for password hiding enabled in #2400. Although not strictly urgent, it makes sense for this to be in the same release.
Other Relevant Parties
None