Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

produce release for linux-arm64 #2395

Merged
merged 5 commits into from
Aug 15, 2023
Merged

produce release for linux-arm64 #2395

merged 5 commits into from
Aug 15, 2023

Conversation

gflex
Copy link
Contributor

@gflex gflex commented Mar 30, 2023

Does this PR modify CLI v6, CLI v7, or CLI v8?

all

Description of the Change

Edit pipelines to produce release for Linux arm64 arch.
included are linux binary, RPM and deb packages

Why Is This PR Valuable?

We need to be able to run the CLI from linux/arm64 architectures.
Chances are we're not in deep need to run it from our RPI's but from linux containers on top of M1/2... Mac.

Why Should This Be In Core?

n/a

Applicable Issues

#2338
#2293

How Urgent Is The Change?

I believe we needed it last year. Second most suitable time would be next release.

Other Relevant Parties

All those fellas in the apple garden running cf from linux containers would benefit. Also those enjoying ARM64 instances in their various clouds.

Copy link
Member

@a-b a-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@a-b
Copy link
Member

a-b commented May 12, 2023

Now we need to update CLAW to support a new type of binary https://github.com/cloudfoundry/CLAW/tree/master
And potentially update RPM and Debian packages to be architecture agnostic.

@gflex
Copy link
Contributor Author

gflex commented May 19, 2023

@a-b, like this cloudfoundry/CLAW#42 ?

@gflex
Copy link
Contributor Author

gflex commented May 23, 2023

anything else needed?

@a-b
Copy link
Member

a-b commented Jun 14, 2023

@gflex, can you please resolve merge conflicts (workflows files got release- prefix) and create PRs for v8 and v7?

@a-b
Copy link
Member

a-b commented Jun 14, 2023

Also, it seems release notes script needs an update

@gflex gflex force-pushed the arm64-release branch 3 times, most recently from 569c534 to 98c13fd Compare June 19, 2023 13:53
@mattreddy3
Copy link

Excited to have this available! Will finally be able to use dev containers on my M1 mac

Copy link
Member

@a-b a-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@a-b
Copy link
Member

a-b commented Jul 13, 2023

@gflex - great work, I think we're very close!

Since we're releasing from v8 and v7 branches respectively, we need to backport this changes to affect the release.

Thanks for your contribution.

@a-b a-b force-pushed the arm64-release branch from 98c13fd to 0e91bac Compare July 13, 2023 21:09
This was referenced Jul 29, 2023
@gflex
Copy link
Contributor Author

gflex commented Jul 29, 2023

@a-b , I hope this time review would not take 2 months. Neither would defects get shown 2 days before next release.

@a-b
Copy link
Member

a-b commented Jul 29, 2023

Would you be interested in helping with pr reviewing and test pipelines?

@a-b a-b merged commit d035a37 into cloudfoundry:main Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants