Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy cfignore to upload directory to properly ignore files #234

Merged
1 commit merged into from
Aug 7, 2014

Conversation

fraenkel
Copy link

The source whether directory or zip starts with a .cfignore.
After we create the temp directory for zipping, the cfignore is ignored in the copy. When zipping, the default ignores only apply.

This fix always copies the cfignore if present so we can properly ignore when zipping.

A current workaround is to ignore the cfignore via !.cfignore.

@cfdreddbot
Copy link

Hey fraenkel!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you've already signed the CLA.

@goehmen
Copy link
Contributor

goehmen commented Jul 31, 2014

* cfignore needs to be in the upload directory when determining what to zip
@ghost
Copy link

ghost commented Aug 7, 2014

Everything looks good here. Comment was a confusing at first, but it makes sense with a given use case.

some_dir/
    file_1
    file_2
    file_3

in .cfignore
   some_dir/
   !some_dir/file_1

This PR properly uploads just the files with the ! in front of them.

ghost pushed a commit that referenced this pull request Aug 7, 2014
Copy cfignore to upload directory to properly ignore files
@ghost ghost merged commit d2f671b into cloudfoundry:master Aug 7, 2014
haydonryan pushed a commit to haydonryan/cli that referenced this pull request Nov 7, 2014
Copy cfignore to upload directory to properly ignore files
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants