Add Isolation Segment #2335
Merged
Add Isolation Segment #2335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allows tests that rely on an isolation segment being available to run
|
integration test didn't run because we ignore the Maybe we shouldn't ignore it? |
Since we can't manually trigger GHA on remote branch from PR. Co-authored-by: Michael Oleske <moleske@pivotal.io>
a-b
approved these changes
Oct 20, 2022
|
Marking as ready since I tested manually against a claimed environment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the CF CLI! Please read the following:
If your contribution falls under a company CLA but your membership is not public, expect delays while we confirm.
Does this PR modify CLI v6, CLI v7, or CLI v8?
This is only for github integration test configuration
Please see the contribution doc above or review Architecture Guide.
Description of the Change
Add isolation segment for testing
We must be able to understand the design of your change from this description.
Keep in mind that the maintainer reviewing this PR may not be familiar with or
have worked with the code here recently, so please walk us through the concepts.
Why Is This PR Valuable?
Cause the tests will actually have all the pre reqs to run
What benefits will be realized by the code change? What users would want this change? What user need is this change addressing?
Why Should This Be In Core?
n/a
Explain why this functionality should be in the cf CLI, as opposed to a plugin.
Applicable Issues
List any applicable Github Issues here
How Urgent Is The Change?
as fast as we want integration tests to work
Is the change urgent? If so, explain why it is time-sensitive.
Other Relevant Parties
@cloudfoundry/wg-app-runtime-interfaces-cli-approvers
@cloudfoundry/wg-app-runtime-interfaces-cli-reviewers
Who else is affected by the change?