Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create and update space quotas #2300

Merged
merged 3 commits into from
Aug 1, 2022
Merged

Create and update space quotas #2300

merged 3 commits into from
Aug 1, 2022

Conversation

ctlong
Copy link
Member

@ctlong ctlong commented Jul 22, 2022

This is blocked on #2299, don't merge before then.

  • create-space-quota accepts -l flag.
  • update-space-quota accepts -l flag.

/cc @mkocher

@ctlong ctlong changed the base branch from master to feature/logging-rate-limits July 22, 2022 00:25
@ctlong ctlong force-pushed the create-and-update-space-quotas branch from f07f630 to 5546583 Compare July 25, 2022 23:11
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 25, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@ctlong ctlong force-pushed the create-and-update-space-quotas branch from c59f48d to 6529f87 Compare July 25, 2022 23:33
@ctlong ctlong mentioned this pull request Jul 26, 2022
Merged
@ctlong ctlong force-pushed the create-and-update-space-quotas branch from 6529f87 to 25c6467 Compare July 26, 2022 18:16
ctlong and others added 3 commits July 26, 2022 22:56
@ctlong
create-space-quota accepts log volume flag
8e0cdb2 
Signed-off-by: Matthew Kocher <mkocher@vmware.com>
@rroberts2222 @ctlong
update-space-quota accepts log volume flag
e0d0273 
Signed-off-by: Carson Long <lcarson@vmware.com>
@ctlong
Update create-space-quota flag description
449345c 
Make it clear that the log volume measured is in bytes rather than log
lines.
@ctlong ctlong force-pushed the create-and-update-space-quotas branch from 25c6467 to 449345c Compare July 26, 2022 22:56
@ctlong ctlong marked this pull request as ready for review July 26, 2022 22:56
@ctlong ctlong mentioned this pull request Jul 26, 2022
Closed
jdgonzaleza
jdgonzaleza approved these changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@jdgonzaleza jdgonzaleza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pivotalgeorge
Copy link
Contributor

This also looks good to me

@pivotalgeorge pivotalgeorge merged commit 950baff into cloudfoundry:feature/logging-rate-limits Aug 1, 2022
rroberts2222 added a commit to loggregator/cli that referenced this pull request Aug 19, 2022
@ctlong @rroberts2222 @mkocher
Create and update space quotas (cloudfoundry#2300)
ef9a266 
* create-space-quota accepts log volume flag

Signed-off-by: Matthew Kocher <mkocher@vmware.com>

* update-space-quota accepts log volume flag

Signed-off-by: Carson Long <lcarson@vmware.com>

* Update create-space-quota flag description

Make it clear that the log volume measured is in bytes rather than log
lines.

Co-authored-by: Rebecca Roberts <robertsre@vmware.com>
rroberts2222 added a commit to loggregator/cli that referenced this pull request Aug 19, 2022
@ctlong @rroberts2222 @mkocher
Create and update space quotas (cloudfoundry#2300)
82d1515 
* create-space-quota accepts log volume flag

Signed-off-by: Matthew Kocher <mkocher@vmware.com>

* update-space-quota accepts log volume flag

Signed-off-by: Carson Long <lcarson@vmware.com>

* Update create-space-quota flag description

Make it clear that the log volume measured is in bytes rather than log
lines.

Co-authored-by: Rebecca Roberts <robertsre@vmware.com>
rroberts2222 added a commit to loggregator/cli that referenced this pull request Aug 19, 2022
@ctlong @rroberts2222 @mkocher
Create and update space quotas (cloudfoundry#2300)
d626572 
* create-space-quota accepts log volume flag

Signed-off-by: Matthew Kocher <mkocher@vmware.com>

* update-space-quota accepts log volume flag

Signed-off-by: Carson Long <lcarson@vmware.com>

* Update create-space-quota flag description

Make it clear that the log volume measured is in bytes rather than log
lines.

Co-authored-by: Rebecca Roberts <robertsre@vmware.com>
jdgonzaleza pushed a commit that referenced this pull request Sep 7, 2022
@ctlong @rroberts2222
Create and update space quotas (#2300)
2f08e2e 
* create-space-quota accepts log volume flag

Signed-off-by: Matthew Kocher <mkocher@vmware.com>

* update-space-quota accepts log volume flag

Signed-off-by: Carson Long <lcarson@vmware.com>

* Update create-space-quota flag description

Make it clear that the log volume measured is in bytes rather than log
lines.

Co-authored-by: Rebecca Roberts <robertsre@vmware.com>
jdgonzaleza added a commit that referenced this pull request Sep 8, 2022
@jdgonzaleza @ctlong
@mkocher @rroberts2222 @Benjamintf1
logging rate limits flag introduction (#2313)
cfcea0f 
* Feat: create and update org quotas with log volume (#2298)

* Show org and space quotas (#2299)

* org-quota and space-quota now show log volume

* code currently assumes responses with log limits. Consider
  backward compatibility before shipping.

* add log volume to space-quotas and org-quotas commands

* will show "unlimited" for old CC API's which is technically correct

* Fix unit tests in ccv3

* Create and update space quotas (#2300)

* create-space-quota accepts log volume flag

* update-space-quota accepts log volume flag

* Update create-space-quota flag description

* Make it clear that the log volume measured is in bytes rather than log
  lines.

* Push and scale app and run-task 

* Bump rack from 2.2.3 to 2.2.3.1 in /fixtures/applications/example-app

* `cf push` command accepts log rate limit flag

* since `cf push` uses manifests this commit also adds support for log
  rate limit in manifests

* `cf scale` command accepts log rate limit flag

* app summary displayer can now handle rendering log rate and log rate
  limit metrics for running instances

* app summaries will show `0 of 0` if the cloud controller does not
  support log rate limit container metrics

* `cf run-task` command accepts log rate limit flag

* update help text to suggest using ='s with -1 to avoid flag parsing problem

* Flag parser accepts 0B, -1B, 0T, etc for flags

* this affects non-manifest based commands

* Extract constants for instance stats columns

* Extract constant for column count

Co-authored-by: Carson Long <lcarson@vmware.com>
Co-authored-by: Matthew Kocher <mkocher@vmware.com>
Co-authored-by: Rebecca Roberts <robertsre@vmware.com>
Co-authored-by: Benjamin Fuller <Benjamintf1@gmail.com>
jdgonzaleza added a commit that referenced this pull request Sep 8, 2022
@jdgonzaleza @ctlong
@mkocher @rroberts2222 @Benjamintf1
logging rate limits flag introduction (#2313)
94619ee 
* Feat: create and update org quotas with log volume (#2298)

* Show org and space quotas (#2299)

* org-quota and space-quota now show log volume

* code currently assumes responses with log limits. Consider
  backward compatibility before shipping.

* add log volume to space-quotas and org-quotas commands

* will show "unlimited" for old CC API's which is technically correct

* Fix unit tests in ccv3

* Create and update space quotas (#2300)

* create-space-quota accepts log volume flag

* update-space-quota accepts log volume flag

* Update create-space-quota flag description

* Make it clear that the log volume measured is in bytes rather than log
  lines.

* Push and scale app and run-task 

* Bump rack from 2.2.3 to 2.2.3.1 in /fixtures/applications/example-app

* `cf push` command accepts log rate limit flag

* since `cf push` uses manifests this commit also adds support for log
  rate limit in manifests

* `cf scale` command accepts log rate limit flag

* app summary displayer can now handle rendering log rate and log rate
  limit metrics for running instances

* app summaries will show `0 of 0` if the cloud controller does not
  support log rate limit container metrics

* `cf run-task` command accepts log rate limit flag

* update help text to suggest using ='s with -1 to avoid flag parsing problem

* Flag parser accepts 0B, -1B, 0T, etc for flags

* this affects non-manifest based commands

* Extract constants for instance stats columns

* Extract constant for column count

Co-authored-by: Carson Long <lcarson@vmware.com>
Co-authored-by: Matthew Kocher <mkocher@vmware.com>
Co-authored-by: Rebecca Roberts <robertsre@vmware.com>
Co-authored-by: Benjamin Fuller <Benjamintf1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdgonzaleza jdgonzaleza jdgonzaleza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ctlong @pivotalgeorge @jdgonzaleza @cf-gitbot @rroberts2222