Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v8] Online release process with Github Actions #2265

Merged
merged 8 commits into from
Apr 19, 2022
Merged

[v8] Online release process with Github Actions #2265

merged 8 commits into from
Apr 19, 2022

Conversation

a-b
Copy link
Member

@a-b a-b commented Mar 11, 2022

The current state of CF CLI release infrastructure is offline and quite outdated. To make our release process more transparent and inclusive we decided to move to build, signing, and release processes online to Github Actions

a-b and others added 6 commits March 11, 2022 09:01
@a-b @pivotalgeorge
Add Buid-Sign-Release workflow
a573021 
Current state of CF CLI release infrastructure is offline and quite
outdated. To make our release process more transparent and inclusive we
decided to move build, signing and release processes online to Github Actions.

Co-authored-by: George Gelashvili <ggelashvili@vmware.com>
@pivotalgeorge @a-b
Split out release/upload part of workflow
3d4b2a7 
Co-authored-by: Alexander Berezovsky <aberezovsky@vmware.com>
@pivotalgeorge @a-b
Add capabilities to release workflow
55117d9 
At this point working in a workflow separate from build, for separation
of concerns between building&signing, and releasing.

This is a squashed commit of the gha-allplatforms branch, consisting of
the following changes :

- Upload mac installer to S3
- include mac installer in github release
- retrieve mac binaries in release job
- add write permission to github release job
- Add linux packages, and simplify CLAW upload steps
- Switch to sync action to support simpler CLAW S3 upload step
- Add linux packages to GH Release
- Update artifact names in release jobs
- aws s3 ls to debug s3 upload
- bump aws s3 sync to non-default-region change

Co-authored-by: Alexander Berezovsky <aberezovsky@vmware.com>
@pivotalgeorge @a-b
Updated for build, release, and units workflows
34b6e9c 
Co-authored-by: Alexander Berezovsky <aberezovsky@vmware.com>
Co-authored-by: Juan Diego Gonzalez <gojuan@vmware.com>
@a-b @pivotalgeorge
Add update-repos workflow
fd3e1b3 
Update-repos workflow is in charge of updating and signing on a
repository level. This workflow should be triggered towards the end of
the release process after all packages are available via distribution
network (after CLAW update). It will update the following repositories:

- Homebrew formula in homebrew-tap git repository
- RPM repo hosted on S3
- Debian repo hosted on S3

Current implementations of the update-repos workflow is matching offline
release process.

Following updates are recommended:

- Implement backup and disaster recovery procedure

- Debian
  - fill license and vendor fields
- RPM
  - sign on the repo level
- Homebrew
  - add arm architecture

Co-authored-by: George Gelashvili <ggelashvili@vmware.com>
@a-b
Release pipelines updates
106db18
@a-b a-b requested review from gururajsh and jdgonzaleza March 18, 2022 19:02
@reedr3 reedr3 self-requested a review March 21, 2022 16:34
reedr3
reedr3 approved these changes Mar 21, 2022
View reviewed changes
Copy link
Contributor

@reedr3 reedr3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

jdgonzaleza
jdgonzaleza reviewed Mar 22, 2022
View reviewed changes
Copy link
Contributor

@jdgonzaleza jdgonzaleza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
Maybe we could delete those commented/unused code

Juan Diego Gonzalez and others added 2 commits April 18, 2022 12:06
@pivotalgeorge
Removes/Cleans comments
c40184e 
Also, small change to sign-windows-binary.ps1 as
that step was already being done in the sign job

Signed-off-by: George Gelashvili <ggelashvili@vmware.com>
@pivotalgeorge
Update github actions secrets template
f034a13 
for use with the set-github-actions-env-vars.sh script,
or the github cli's 'secret set' subcommand directly

Signed-off-by: Pete Levine <lpete@vmware.com>
@a-b a-b removed the request for review from gururajsh April 18, 2022 21:10
a-b
a-b commented Apr 18, 2022
View reviewed changes
Copy link
Member Author

@a-b a-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pivotalgeorge
Copy link
Contributor

LGTM

@a-b a-b mentioned this pull request Apr 18, 2022
Closed
@pivotalgeorge pivotalgeorge merged commit d201936 into v8 Apr 19, 2022
PeteLevineA pushed a commit that referenced this pull request May 5, 2022
@a-b @pivotalgeorge
[v8] Online release process with Github Actions (#2265)
b04b29d 
* Add Build-Sign-Release workflow

Commit summary below

Current state of CF CLI release infrastructure is offline and quite
outdated. To make our release process more transparent and inclusive we
decided to move build, signing and release processes online to Github Actions.
* Split out release/upload part of workflow
* Add capabilities to release workflow

At this point working in a workflow separate from build, for separation
of concerns between building&signing, and releasing.

This is a squashed commit of the gha-allplatforms branch, consisting of
the following changes :

- Upload mac installer to S3
- include mac installer in github release
- retrieve mac binaries in release job
- add write permission to github release job
- Add linux packages, and simplify CLAW upload steps
- Switch to sync action to support simpler CLAW S3 upload step
- Add linux packages to GH Release
- Update artifact names in release jobs
- aws s3 ls to debug s3 upload
- bump aws s3 sync to non-default-region change

* Updated for build, release, and units workflows
* Add update-repos workflow

Update-repos workflow is in charge of updating and signing on a
repository level. This workflow should be triggered towards the end of
the release process after all packages are available via distribution
network (after CLAW update). It will update the following repositories:

- Homebrew formula in homebrew-tap git repository
- RPM repo hosted on S3
- Debian repo hosted on S3

Current implementations of the update-repos workflow is matching offline
release process.

Following updates are recommended:

- Implement backup and disaster recovery procedure

- Debian
  - fill license and vendor fields
- RPM
  - sign on the repo level
- Homebrew
  - add arm architecture

* Release pipelines updates
* Removes/Cleans comments

Also, small change to sign-windows-binary.ps1 as
that step was already being done in the sign job

* Update github actions secrets template

for use with the set-github-actions-env-vars.sh script,
or the github cli's 'secret set' subcommand directly

Co-authored-by: Alexander Berezovsky <aberezovsky@vmware.com>
Co-authored-by: George Gelashvili <ggelashvili@vmware.com>
Co-authored-by: Juan Diego Gonzalez <gojuan@vmware.com>
Signed-off-by: Pete Levine <lpete@vmware.com>
gururajsh pushed a commit that referenced this pull request May 17, 2022
@a-b @pivotalgeorge @gururajsh
[v8] Online release process with Github Actions (#2265)
9ad973b 
* Add Build-Sign-Release workflow

Commit summary below

Current state of CF CLI release infrastructure is offline and quite
outdated. To make our release process more transparent and inclusive we
decided to move build, signing and release processes online to Github Actions.
* Split out release/upload part of workflow
* Add capabilities to release workflow

At this point working in a workflow separate from build, for separation
of concerns between building&signing, and releasing.

This is a squashed commit of the gha-allplatforms branch, consisting of
the following changes :

- Upload mac installer to S3
- include mac installer in github release
- retrieve mac binaries in release job
- add write permission to github release job
- Add linux packages, and simplify CLAW upload steps
- Switch to sync action to support simpler CLAW S3 upload step
- Add linux packages to GH Release
- Update artifact names in release jobs
- aws s3 ls to debug s3 upload
- bump aws s3 sync to non-default-region change

* Updated for build, release, and units workflows
* Add update-repos workflow

Update-repos workflow is in charge of updating and signing on a
repository level. This workflow should be triggered towards the end of
the release process after all packages are available via distribution
network (after CLAW update). It will update the following repositories:

- Homebrew formula in homebrew-tap git repository
- RPM repo hosted on S3
- Debian repo hosted on S3

Current implementations of the update-repos workflow is matching offline
release process.

Following updates are recommended:

- Implement backup and disaster recovery procedure

- Debian
  - fill license and vendor fields
- RPM
  - sign on the repo level
- Homebrew
  - add arm architecture

* Release pipelines updates
* Removes/Cleans comments

Also, small change to sign-windows-binary.ps1 as
that step was already being done in the sign job

* Update github actions secrets template

for use with the set-github-actions-env-vars.sh script,
or the github cli's 'secret set' subcommand directly

Co-authored-by: Alexander Berezovsky <aberezovsky@vmware.com>
Co-authored-by: George Gelashvili <ggelashvili@vmware.com>
Co-authored-by: Juan Diego Gonzalez <gojuan@vmware.com>
Signed-off-by: Pete Levine <lpete@vmware.com>
gururajsh added a commit that referenced this pull request May 17, 2022
@gururajsh
Revert "[v8] Online release process with Github Actions (#2265)"
5d45c5e 
This reverts commit 9ad973b.
gururajsh added a commit that referenced this pull request May 17, 2022
@gururajsh
Revert "[v8] Online release process with Github Actions (#2265)"
baada49 
This reverts commit 9ad973b.
@moleske moleske deleted the gh-actions-v8-squashed branch August 24, 2023 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdgonzaleza jdgonzaleza jdgonzaleza left review comments

@reedr3 reedr3 reedr3 approved these changes

@hjcalderon10 hjcalderon10 hjcalderon10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@a-b @pivotalgeorge @hjcalderon10 @reedr3 @jdgonzaleza @cf-gitbot