Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the tip for security groups #2254

Merged
merged 1 commit into from
Feb 16, 2022
Merged

Update the tip for security groups #2254

merged 1 commit into from
Feb 16, 2022

Conversation

mariash
Copy link
Member

@mariash mariash commented Feb 15, 2022

When users have dynamic ASG's feature enabled they don't need to
restart/restage their application for security group updates to take and
effect.

Thank you for contributing to the CF CLI! Please read the following:

  • Please make sure you have implemented changes in line with the contributing guidelines
  • We're not allowed to accept any PRs without a signed CLA, no matter how small.
    If your contribution falls under a company CLA but your membership is not public, expect delays while we confirm.
  • All new code requires tests to protect against regressions.
  • Contributions must be made against the appropriate branch. See the contributing guidelines
  • Contributions must conform to our style guide. Please reach out to us if you have questions.

Does this PR modify CLI v6, CLI v7, or CLI v8?

v7, v8, v9

Description of the Change

TAS 2.13 introduces dynamic asgs feature which automatically updates security-groups for running and staging applications without the need for restart after security-groups were added/updated or removed.

Why Is This PR Valuable?

Users will see the new tip after they run security-groups commands like (bind-security-group, unbind-security-group and update-security-group) that their changes will be applied automatically if they have dynamic asgs enabled.

Why Should This Be In Core?

Because it is currently in core and provides incorrect tip.

Applicable Issues

Original issue in cf-networking release

How Urgent Is The Change?

We need this to be released for 2.13 (code freeze February 21, 2022)

When users have dynamic ASG's feature enabled they don't need to
restart/restage their application for security group updates to take and
effect.
Copy link
Contributor

@jdgonzaleza jdgonzaleza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants