Fix inter-woven output during start #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 25, 2014 11:23
Signed-off-by: Aram Price <aprice@pivotallabs.com>
Signed-off-by: Aram Price <aprice@pivotallabs.com>
|
We have created an issue in Pivotal Tracker to manage this. You can view the current status of your issue at: https://www.pivotaltracker.com/story/show/75733456. |
crhino
added a commit
that referenced
this pull request
Jul 25, 2014
Fix inter-woven output during start
|
Looks good. One note: we're preferring to say things like rather than partially for legibility and partially because the second form confuses counterfeiter. Not a big enough deal to block the merge, though. |
|
@crhino, counterfeiter is no longer confused by that pattern FYI. Thanks! |
|
@tedsuo - Well then, I'll just have to dislike it for purely aesthetic reasons. Your PR is still merged. :P |
haydonryan
pushed a commit
to haydonryan/cli
that referenced
this pull request
Nov 7, 2014
Fix inter-woven output during start
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now wait until log messages are fully flushed before displaying instance status.
Also, we switched the FakeLogsRepository to be generated by counterfeiter.