Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix lint errors #2246

Merged
merged 1 commit into from
Jul 12, 2022
Merged

fix lint errors #2246

merged 1 commit into from
Jul 12, 2022

Conversation

metskem
Copy link
Contributor

@metskem metskem commented Jan 24, 2022

Thank you for contributing to the CF CLI! Please read the following:

  • Please make sure you have implemented changes in line with the contributing guidelines
  • We're not allowed to accept any PRs without a signed CLA, no matter how small.
    If your contribution falls under a company CLA but your membership is not public, expect delays while we confirm.
  • All new code requires tests to protect against regressions.
  • Contributions must be made against the appropriate branch. See the contributing guidelines
  • Contributions must conform to our style guide. Please reach out to us if you have questions.

Does this PR modify CLI v6, CLI v7, or CLI v8?

Please see the contribution doc above or review Architecture Guide.

Description of the Change

Fix lint errors.

  • imports ordering/grouping
  • redundant null check
  • unused function
  • unchecked errors

Why Is This PR Valuable?

So, you can do a successful "make" .

Why Should This Be In Core?

So you can make lint.

Applicable Issues

none

How Urgent Is The Change?

Not urgent

Other Relevant Parties

everyone that runs the lint checks

@metskem metskem mentioned this pull request Jan 24, 2022
1 task
@ccjaimes ccjaimes merged commit e59699e into cloudfoundry:master Jul 12, 2022
rroberts2222 pushed a commit to loggregator/cli that referenced this pull request Aug 19, 2022
rroberts2222 pushed a commit to loggregator/cli that referenced this pull request Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants