[Feature] Add app-protocol to cf routes command output #2234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 17, 2021 23:03
Currently we do not show the app-protocol in the output of the cf routes command, so a new column must be added to the output. Also, the apps mapped to the route should be displayed in the apps column and must be separated with commas.
03e1534 to
3deb205
Compare
hjcalderon10
approved these changes
Nov 22, 2021
a-b
reviewed
Nov 22, 2021
| @@ -928,13 +936,18 @@ var _ = Describe("Route Actions", func() { | |||
|
|
|||
| for i := 0; i < batcher.BatchSize*batches; i++ { | |||
| port := i + 1000 | |||
| appProtocol := "http1" | |||
| if i%2 == 0 { | |||
hjcalderon10
pushed a commit
that referenced
this pull request
Nov 23, 2021
Currently we do not show the app-protocol in the output of the cf routes command, so a new column must be added to the output. Also, the apps mapped to the route should be displayed in the apps column and must be separated with commas. Co-authored-by: Hector Calderon <hecalderon@vmware.com>
hjcalderon10
pushed a commit
that referenced
this pull request
Feb 7, 2022
Currently we do not show the app-protocol in the output of the cf routes command, so a new column must be added to the output. Also, the apps mapped to the route should be displayed in the apps column and must be separated with commas. Co-authored-by: Hector Calderon <hecalderon@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we do not show the app-protocol in the output of the cf routes command, so a new column must be added to the output.
Also, the apps mapped to the route should be displayed in the apps column and must be separated with commas.
When running the
cf routescommand I'm able to see the app-protocol column in the output and the value for it should be a comma separated list that contains http1 and/or http2. This is in the case that the route is an HTTP route.