[Feature] Rename flag to app-protocol in map-route #2231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the cli already has a flag named destination-protocol and in order to have consistency we need to rename it to app-protocol Co-authored-by: Hector Calderon <hecalderon@vmware.com>
hjcalderon10
approved these changes
Nov 12, 2021
jdgonzaleza
added a commit
that referenced
this pull request
Nov 16, 2021
Currently the cli already has a flag named destination-protocol and in order to have consistency we need to rename it to app-protocol Co-authored-by: Hector Calderon <hecalderon@vmware.com>
hjcalderon10
pushed a commit
that referenced
this pull request
Feb 7, 2022
Currently the cli already has a flag named destination-protocol and in order to have consistency we need to rename it to app-protocol Co-authored-by: Hector Calderon <hecalderon@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the following command
cf map-route my-app example.com --hostname myhost --app-protocol http2the following output should be generated: