Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] support HTTP/2 - Rename protocol to app-protocol to cf route command #2230

Merged
merged 1 commit into from
Nov 10, 2021
Merged

[Feature] support HTTP/2 - Rename protocol to app-protocol to cf route command #2230

merged 1 commit into from
Nov 10, 2021

Conversation

jdgonzaleza
Copy link
Contributor

I want to see the app-protocol instead of protocol in the header of the cf route command output.

When running the cf route command must be able to see the app-protocol column in the output

$ cf route mydomain.cli.fun --hostname pora
domain:     mydomain.cli.fun
host:       pora
port:
path:
protocol:   http

app    process   port   app-protocol
pora   web       8080   http2

[Feature] support HTTP/2 cf command
8d10599 
[reason] Renaming "protocol" column to "app-protocol"
in the destination table of the cf route command

Co-authored-by: Hector Calderon <hecalderon@vmware.com>
a-b
a-b approved these changes Nov 10, 2021
View reviewed changes
Copy link
Member

@a-b a-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdgonzaleza jdgonzaleza merged commit bbc9ee9 into master Nov 10, 2021
@a-b a-b deleted the feature/cf-route-rename-protocol-column branch November 10, 2021 23:05
hjcalderon10 pushed a commit that referenced this pull request Nov 11, 2021
@jdgonzaleza
[Feature] support HTTP/2 cf command (#2230)
5ed753d 
[reason] Renaming "protocol" column to "app-protocol"
in the destination table of the cf route command

Co-authored-by: Hector Calderon <hecalderon@vmware.com>
jdgonzaleza pushed a commit that referenced this pull request Nov 23, 2021
Revert route and routes commands HTTP/2 support(#2230)
685c102 
Co-authored-by: Hector Calderon <hecalderon@vmware.com>
hjcalderon10 pushed a commit that referenced this pull request Feb 7, 2022
@jdgonzaleza
[Feature] support HTTP/2 cf command (#2230)
d5af404 
[reason] Renaming "protocol" column to "app-protocol"
in the destination table of the cf route command

Co-authored-by: Hector Calderon <hecalderon@vmware.com>
hjcalderon10 pushed a commit that referenced this pull request Mar 9, 2022
Revert route and routes commands HTTP/2 support(#2230)
0feb898 
Co-authored-by: Hector Calderon <hecalderon@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjcalderon10 hjcalderon10 hjcalderon10 approved these changes

@a-b a-b a-b approved these changes

@sebGilR sebGilR Awaiting requested review from sebGilR

@bepotts bepotts Awaiting requested review from bepotts

@reedr3 reedr3 Awaiting requested review from reedr3

@dominicrobertsc dominicrobertsc Awaiting requested review from dominicrobertsc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jdgonzaleza @a-b @hjcalderon10 @cf-gitbot