Implement cf route command
#2205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`cf route` can be used to see details about a route and mapped destinations. Handles http & tcp routes. Shows http1/http2/tcp protocol for destinations. Will not error if used on older cloud controllers but destination protocols will be blank. Co-authored-by: Matthew Kocher <mkocher@pivotal.io> Co-authored-by: Merric de Launey <mdelauney@pivotal.io>
jdgonzaleza
reviewed
Sep 10, 2021
| {"routes", "create-route", "check-route", "map-route", "unmap-route", "delete-route", "delete-orphaned-routes"}, | ||
| {"routes", "route"}, | ||
| {"create-route", "check-route", "map-route", "unmap-route", "delete-route"}, | ||
| {"delete-orphaned-routes"}, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cf routecan be used to see details about a route and mapped destinations. Handles http & tcp routes. Shows http1/http2/tcp protocol for destinations.Will not error if used on older cloud controllers but destination protocols will be blank.
Co-authored-by: Matthew Kocher mkocher@pivotal.io
Co-authored-by: Merric de Launey mdelauney@pivotal.io
Does this PR modify CLI v6 or v7?
Targeting v8 for now. May need to be backported to v7 at some point.
Description of the Change
Adds command to see route details.
Why Should This Be In Core?
Routes are a build in feature of CF
Applicable Issues
#2187
cloudfoundry/routing-release#200
How Urgent Is The Change?
Looking to declare GA support for http2 soon.
Integration Tests
We added integration tests and made them pass. Some integration tests were failing on our environment that seemed unrelated.