2169 rolling deploy timeout issue #2170
Conversation
issue #2169 Co-authored-by: Teal Stannard <tstannard@pivotal.io> Co-authored-by: Seth Boyles <sboyles@pivotal.io>
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/178309610 The labels on this github issue will be updated when the story is started. |
|
@tstannard please authorize the CLA 🌝 |
canceled Co-authored-by: Jenna Goldstrich <jgoldstrich@pivotal.io> Co-authored-by: Seth Boyles <sboyles@pivotal.io>
cd86a64 to
8744231
Compare
|
hi CLI, |
|
@tstannard and @JenGoldstrich these changes are only applicable to the |
|
@a-b we actually want these changes on v7 and v8, as they mostly just make v7 rolling push failures a little more graceful. Should we open a second PR for to the v7 branch? How would y'all prefer we submit PRs that are intended for v7 and v8? |
|
Thanks for the clarification. No need to make additional PR we will take care of that. |
|
Merging this based on Alex signing off on it. |
Merge pull request #2170 from cloudfoundry/2169-rolling-deploy-timeout-issue 2169 rolling deploy timeout issue
Does this PR modify CLI v6 or v7?
v8
Description of the Change
Resolves #2169
Currently, when a push with strategy=rolling takes longer than
CF_STARTUP_TIMEOUT, the CLI exits 1 but the deployment continues to attempt bringing up new instances of the app indefinitely. With this change, when the CLI times out, it makes an additional call to CAPI to cancel the deployment, mirroring behavior similar to a non-rolling push.How Urgent Is The Change?
not urgent, but an annoying bug