Fix stack being over-ridden everytime in v7 push #2148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whenever an app was pushed in v7 if the manifest had a stack field in it, it would be always overriden by the cf CLI with whatever you put in for -s on cf push, even if you did not submit this flag. Thus leading to stack always being an empty string in those situations. Co-authored-by: Jenna Goldstrich <jgoldstrich@pivotal.io> Co-authored-by: Teal Stannard <tstannard@pivotal.io>
|
|
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/177048452 The labels on this github issue will be updated when the story is started. |
|
@thausler786 can you please review the proposed change from the product perspective? |
|
This is a change in behavior we will have to call out in the release notes. Reading the command I believe the user would clearly expect that the CLI would use the stack in the manifest as given, so this is a straightforward bug fix that should be included, even if it does cause a change in behavior. |
|
cc @reedr3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR modify CLI v6 or v7?
v7
Description of the Change
When v7 push is called with a manifest that has a stack field set, the cf CLI would override that field to an empty string. This PR makes it so that we only override the stack field in the manifest when a user provides a stack with the -s flag.
Why Is This PR Valuable?
When users set the stack field in their manifest, they would like to use it.
Why Should This Be In Core?
Bug fix.
Applicable Issues
cloudfoundry/cloud_controller_ng#1819
How Urgent Is The Change?
We would like this shipped in the next minor v7 release
Other Relevant Parties
@amhuber who reported this issue