v8(services): remove detection of UPSI for keys #2140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We decided that the CLI should have no knowledge of the restriction that user-provided service instances cannot have service keys. While there is no plan to change that restriction, we should avoid duplicating checks in the CLI that are also performed in the cloud controller so that the checks do not get out of step in the future. [#176719946](https://www.pivotaltracker.com/story/show/176719946)
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/176960737 The labels on this github issue will be updated when the story is started. |
FelisiaM
approved these changes
Feb 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We decided that the CLI should have no knowledge of the restriction that
user-provided service instances cannot have service keys. While there is
no plan to change that restriction, we should avoid duplicating checks
in the CLI that are also performed in the cloud controller so that the
checks do not get out of step in the future.
#176719946