Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove redundant reference to version switching #2118

Merged
merged 1 commit into from
Dec 17, 2020

Conversation

heyjcollins
Copy link
Contributor

It was broken also because it was an inline reference that we should have removed when we moved the version switching guide to it's own page.

Thank you for contributing to the CF CLI! Please read the following:

  • Please make sure you have implemented changes in line with the contributing guidelines
  • We're not allowed to accept any PRs without a signed CLA, no matter how small.
    If your contribution falls under a company CLA but your membership is not public, expect delays while we confirm.
  • All new code requires tests to protect against regressions.
  • Contributions must be made against the appropriate branch. See the contributing guidelines
  • Contributions must conform to our style guide. Please reach out to us if you have questions.

Does this PR modify CLI v6 or v7?

Please see the contribution doc above or review Architecture Guide.

Description of the Change

We must be able to understand the design of your change from this description.
Keep in mind that the maintainer reviewing this PR may not be familiar with or
have worked with the code here recently, so please walk us through the concepts.

Why Is This PR Valuable?

What benefits will be realized by the code change? What users would want this change? What user need is this change addressing?

Why Should This Be In Core?

Explain why this functionality should be in the cf CLI, as opposed to a plugin.

Applicable Issues

List any applicable Github Issues here

How Urgent Is The Change?

Is the change urgent? If so, explain why it is time-sensitive.

Other Relevant Parties

Who else is affected by the change?

It was broken also because it was an inline reference that we should have removed when we moved the version switching guide to it's own page.
@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/176099460

The labels on this github issue will be updated when the story is started.

@reidmit
Copy link
Contributor

reidmit commented Dec 17, 2020

Looks good to me. Thanks @heyjcollins!

@reidmit reidmit merged commit 3c7fba4 into cloudfoundry:master Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants