New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use tagged literals when adding flags. #16

Merged

cf-services merged 1 commit into cloudfoundry:master from acrmp:vet-use-tagged-literals

Oct 9, 2013

Member

acrmp commented Oct 7, 2013

Running go vet on the code reports warnings for the flags defined in app.go:

src/cf/app/app.go:110: cli.BoolFlag composite literal uses untagged fields

Though the alternative here seems quite verbose.

Cheers,

Andrew.


          Use tagged literals when adding flags.

7f5ffef

Contributor

scottruitt commented Oct 8, 2013

Thanks, Andrew! We'll merge your PR in the next few days.

cf-services merged commit 7f5ffef into cloudfoundry:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet