app manifest should support referencing a docker image with docker registry

[jbayer]

i didn't see support for it here and assume that it means there is no support for specifying a docker image reference in a cf app manifest.yml

cli/cf/manifest/manifest.go

Lines 167 to 223 in aa1c389

	func mapToAppParams(basePath string, yamlMap generic.Map) (models.AppParams, error) {
	err := checkForNulls(yamlMap)
	if err != nil {
	return models.AppParams{}, err
	}
	var appParams models.AppParams
	var errs []error
	appParams.BuildpackUrl = stringValOrDefault(yamlMap, "buildpack", &errs)
	appParams.DiskQuota = bytesVal(yamlMap, "disk_quota", &errs)
	domainAry := *sliceOrEmptyVal(yamlMap, "domains", &errs)
	if domain := stringVal(yamlMap, "domain", &errs); domain != nil {
	domainAry = append(domainAry, *domain)
	}
	appParams.Domains = removeDuplicatedValue(domainAry)
	hostsArr := *sliceOrEmptyVal(yamlMap, "hosts", &errs)
	if host := stringVal(yamlMap, "host", &errs); host != nil {
	hostsArr = append(hostsArr, *host)
	}
	appParams.Hosts = removeDuplicatedValue(hostsArr)
	appParams.Name = stringVal(yamlMap, "name", &errs)
	appParams.Path = stringVal(yamlMap, "path", &errs)
	appParams.StackName = stringVal(yamlMap, "stack", &errs)
	appParams.Command = stringValOrDefault(yamlMap, "command", &errs)
	appParams.Memory = bytesVal(yamlMap, "memory", &errs)
	appParams.InstanceCount = intVal(yamlMap, "instances", &errs)
	appParams.HealthCheckTimeout = intVal(yamlMap, "timeout", &errs)
	appParams.NoRoute = boolVal(yamlMap, "no-route", &errs)
	appParams.NoHostname = boolVal(yamlMap, "no-hostname", &errs)
	appParams.UseRandomHostname = boolVal(yamlMap, "random-route", &errs)
	appParams.ServicesToBind = sliceOrEmptyVal(yamlMap, "services", &errs)
	appParams.EnvironmentVars = envVarOrEmptyMap(yamlMap, &errs)
	appParams.HealthCheckType = stringVal(yamlMap, "health-check-type", &errs)
	if appParams.Path != nil {
	path := *appParams.Path
	if filepath.IsAbs(path) {
	path = filepath.Clean(path)
	} else {
	path = filepath.Join(basePath, path)
	}
	appParams.Path = &path
	}
	if len(errs) > 0 {
	message := ""
	for _, err := range errs {
	message = message + fmt.Sprintf("%s\n", err.Error())
	}
	return models.AppParams{}, errors.New(message)
	}
	return appParams, nil
	}

[cf-gitbot]

We have created an issue in Pivotal Tracker to manage this. You can view the current status of your issue at: https://www.pivotaltracker.com/story/show/108983470.

[dkoper]

Hi @jbayer,

Correct. We are focusing on exposing back-end features such as the routing related ones and manifest support is falling behind. It hasn't fallen off my radar though!

Regards,
Dies Koper
CF CLI PM

[dkoper]

@SocalNick The docker upload API is still marked experimental. What are the plans with it?
http://apidocs.cloudfoundry.org/238/apps/creating_a_docker_app_%28experimental%29.html

[jbayer]

i'm not aware of reasons it should still marked experimental. are there any?

/cc @dieucao

[SocalNick]

Maybe because docker_credentials_json and ports are still experimental? We can remove the experimental tag from the top-level if you like. Story: https://www.pivotaltracker.com/story/show/126058395

FWIW, we intend to remove docker_credentials_json as part of this story until we officially tackle private docker repos: https://www.pivotaltracker.com/story/show/92603918

[rohitgkk]

Hi @SocalNick and @dkoper
there is a manifest.yml option docker_image: which can be used to push cloud foundry image but I was unable to do so.

My question is can we push docker image via manifest? ( docker_image: )

[jbayer]

@dkoper @dieucao @zrob now that there is proper private docker repository support in CF, not having a docker image manifest option is one of the last things needed to make the docker image experience 1st class. is support for this planned?

[dkoper]

@jbayer Definitely!

[wmnnd]

@dkoper Great to hear that Docker support is now planned for manifests. Is there an ETA when we can expect this feature?

[kindrowboat]

👍

[dkoper]

@wmnnd, @motevets Are you planning to use only public Docker images, or also from private Docker repositories?

The story for Docker image support in manifests is currently scheduled for delivery in 1-2 months.
Private Docker repo support in manifest files may take longer: we need to explore a solution where we preferably not force people to include secrets in their app manifest.

The ETA for the former is based on the current refactor of push (and subsequent refactor of create-app-manifest): current push has a lot of code and not written well to be easily extended. We're cleaning it up (and adding lots of tests) to make it easier to enhance, but that takes time.

If demand is high enough, we can at least investigate how much effort and risk is involved in implementing it in the current push ahead of the refactor completion...

[wmnnd]

@dkoper I am using only private registries. For now, I am using cf curl /v2/apps with a JSON file that looks something like a manifest already and then a shell script to attach the necessary services and routes:

{
  "name": "myapp",
  "memory": 128,
  "space_guid": "…",
  "docker_image": "my.registry/image",
  "docker_credentials": {
    "username": "foo",
    "password": "bar"
  },
  "environment_json": {
    "FOO": "bar"
  },
  "diego": true
}

If I may make a suggestion about avoiding putting the credentials for private registries in the manifest: You already have CF_DOCKER_PASSWORD, so if you added CF_DOCKER_USER, I think all would be good 😄

[kindrowboat]

My use case at the time was for a public image, but I would find private images useful in the future. I like solution @wmnnd proposed using environment variables. I'm also not scared of putting credentials in my manifest because I already put sensitive environment variables in my manifest, but don't check it in with the source code.

…

On Thu, Jul 13, 2017, 3:33 AM Philipp ***@***.***> wrote: @dkoper <https://github.com/dkoper> I am using only private registries. For now, I am using cf curl /v2/apps with a JSON file that looks something like a manifest already and then a shell script to attach the necessary services and routes: { "name": "myapp", "memory": 128, "space_guid": "…", "docker_image": "my.registry/image", "docker_credentials": { "username": "foo", "password": "bar" }, "environment_json": { "FOO": "bar" }, "diego": true } If I may make a suggestion about avoiding putting the credentials for private registries in the manifest: You already have CF_DOCKER_PASSWORD, so if you added CF_DOCKER_USER, I think all would be good 😄 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#696 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAveLYoElgsuYFVicRtY63Aybatg6oVMks5sNfKBgaJpZM4GpiLu> .

[dkoper]

This feature is now supported in cf CLI 6.31.0 onwards.
For now the username can be set in the app manifest and the password passed in with an environment variable. We are exploring other ways to provide both in the future.