Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

download-droplet not working in v8 with S3 object store #2225

Closed
4 tasks done
amhuber opened this issue Oct 28, 2021 · 4 comments
Closed
4 tasks done

download-droplet not working in v8 with S3 object store #2225

amhuber opened this issue Oct 28, 2021 · 4 comments

Comments

@amhuber
Copy link

amhuber commented Oct 28, 2021

Please fill out the issue checklist below and provide ALL the requested information.

  • I reviewed open and closed github issues that may be related to my problem.
  • I tried updating to the latest version of the CF CLI to see if it fixed my problem.
  • I attempted to run the command with CF_TRACE=1 to help debug the issue.
  • I am reporting a bug that others will be able to reproduce.

Describe the bug and the command you saw an issue with
Due to the same root cause from #1165, the download-droplet command is not working in the v8 version of the CLI.

What happened
Using the download-droplet command using CLI v8 throws an error due to the Content-Type header included in the request.

Expected behavior
The download-droplet command should work to download the droplet from the object store.

Exact Steps To Reproduce

  1. Run cf8 -v download-droplet appname
  2. Receive error from S3: The request signature we calculated does not match the signature you provided
  3. Run cf7 -v download-droplet appname
  4. Droplet is downloaded successfully

Provide more context

  • Windows 10
  • CLI v8.0.0

Relevant trace output:

v7.3.0:

REQUEST: [2021-10-28T14:56:11-07:00]
GET /v3/droplets/7514513a-e8b7-459c-a0f6-ad63b178f269/download HTTP/1.1
Host: api.domain.com
Accept: application/json
Authorization: [PRIVATE DATA HIDDEN]
User-Agent: cf7.exe/7.3.0+645c3ce6a.2021-08-16 (go1.16.6; amd64 windows)

v8.0.0:

REQUEST: [2021-10-28T14:58:20-07:00]
GET /v3/droplets/7514513a-e8b7-459c-a0f6-ad63b178f269/download HTTP/1.1
Host: api.domain.com
Accept: application/json
Authorization: [PRIVATE DATA HIDDEN]
Content-Type: application/json
User-Agent: cf8.exe/8.0.0+e8d41cf8e.2021-09-16 (go1.16.6; amd64 windows)

The added Content-Type header is causing the issue in v8.
@kirkfox
Copy link

kirkfox commented Oct 4, 2023

Is this on the roadmap?

johha added a commit to cloudfoundry/capi-bara-tests that referenced this issue Mar 28, 2024
@johha
Download droplet with curl
75ee5a7 
`cf curl` or `cf download-droplet` can cause errors e.g. when using a
GCP blobstore due to a issue with the content type.

With using curl we can work around this issue.
More details can be found here:
cloudfoundry/cli#2225
@johha johha mentioned this issue Mar 28, 2024
Merged
@Samze
Copy link
Contributor

Samze commented Jul 22, 2024

@gururajsh should #2976 have resolved this?

@gururajsh
Copy link
Member

Yes, it should be resolved now

@Samze
Copy link
Contributor

Samze commented Jul 23, 2024

Closing this @amhuber as fixed in #2976, please reopen if you see this issue again

@Samze Samze closed this as completed Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Samze @amhuber @kirkfox @gururajsh