Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CF CLI 6.3.0 default domain selection change #209

Closed
youngm opened this issue Jul 15, 2014 · 2 comments
Closed

CF CLI 6.3.0 default domain selection change #209

youngm opened this issue Jul 15, 2014 · 2 comments
Labels

Comments

@youngm
Copy link
Contributor

youngm commented Jul 15, 2014

Default domain selection logic changed.

It appears that with this commit: 3af86c8#diff-8f8f9c2c426a059e52235666445f297f

The logic for default domain selection on push has changed. Instead of returning the first shared domain it appears to now return the last private domain.

Is this change deliberate?

For my use cases private domains typically make a poor default selection but I can see how this may not be the case for others.

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this. You can view the current status of your issue at: https://www.pivotaltracker.com/story/show/75067850.

@lcddave lcddave added the bug label Jul 15, 2014
@lcddave
Copy link
Contributor

lcddave commented Jul 15, 2014

This is a bug. We'll fix it.

@crhino crhino closed this as completed in 93ffe98 Jul 15, 2014
haydonryan pushed a commit to haydonryan/cli that referenced this issue Nov 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants