Cf space-users now lists space supporters

fixes #2219 [finishes #179982523] Authored-by: Merric de Launey <mdelauney@pivotal.io>
cloudfoundry · Oct 26, 2021 · f35afe0 · f35afe0
1 parent 9159087
commit f35afe0
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 0 deletions.
diff --git a/command/v7/space_users_command.go b/command/v7/space_users_command.go
@@ -58,6 +58,7 @@ func (cmd *SpaceUsersCommand) Execute(args []string) error {
 func (cmd SpaceUsersCommand) displaySpaceUsers(orgUsersByRoleType map[constant.RoleType][]resources.User) {
 	cmd.displayRoleGroup(orgUsersByRoleType[constant.SpaceManagerRole], "SPACE MANAGER")
 	cmd.displayRoleGroup(orgUsersByRoleType[constant.SpaceDeveloperRole], "SPACE DEVELOPER")
+	cmd.displayRoleGroup(orgUsersByRoleType[constant.SpaceSupporterRole], "SPACE SUPPORTER")
 	cmd.displayRoleGroup(orgUsersByRoleType[constant.SpaceAuditorRole], "SPACE AUDITOR")
 }
 

diff --git a/command/v7/space_users_command_test.go b/command/v7/space_users_command_test.go
@@ -167,6 +167,11 @@ var _ = Describe("space-users Command", func() {
 								PresentationName: "billing-manager",
 								GUID:             "spaceDeveloper-guid",
 							}
+							spaceSupporter := resources.User{
+								Origin:           "uaa",
+								PresentationName: "fred",
+								GUID:             "spaceSupporter-guid",
+							}
 							spaceAuditor := resources.User{
 								Origin:           "uaa",
 								PresentationName: "org-auditor",
@@ -176,6 +181,7 @@ var _ = Describe("space-users Command", func() {
 							spaceUsersByRole := map[constant.RoleType][]resources.User{
 								constant.SpaceManagerRole:   {uaaAdmin, ldapAdmin, abbyUser, client},
 								constant.SpaceDeveloperRole: {spaceDeveloper},
+								constant.SpaceSupporterRole: {spaceSupporter},
 								constant.SpaceAuditorRole:   {spaceAuditor},
 							}
 
@@ -199,6 +205,9 @@ var _ = Describe("space-users Command", func() {
 							Expect(testUI.Out).To(Say(`\nSPACE DEVELOPER`))
 							Expect(testUI.Out).To(Say(`\n  billing-manager \(uaa\)`))
 							Expect(testUI.Out).To(Say(`\n`))
+							Expect(testUI.Out).To(Say(`\nSPACE SUPPORTER`))
+							Expect(testUI.Out).To(Say(`\n  fred \(uaa\)`))
+							Expect(testUI.Out).To(Say(`\n`))
 							Expect(testUI.Out).To(Say(`\nSPACE AUDITOR`))
 							Expect(testUI.Out).To(Say(`\n  org-auditor \(uaa\)`))
 

diff --git a/integration/v7/isolated/space_users_command_test.go b/integration/v7/isolated/space_users_command_test.go
@@ -45,12 +45,14 @@ var _ = Describe("space-users command", func() {
 			var (
 				spaceManagerUser   string
 				spaceDeveloperUser string
+				spaceSupporterUser string
 				spaceAuditorUser1  string
 			)
 
 			BeforeEach(func() {
 				spaceManagerUser, _ = helpers.CreateUserInSpaceRole(orgName, spaceName, "SpaceManager")
 				spaceDeveloperUser, _ = helpers.CreateUserInSpaceRole(orgName, spaceName, "SpaceDeveloper")
+				spaceSupporterUser, _ = helpers.CreateUserInSpaceRole(orgName, spaceName, "SpaceSupporter")
 				spaceAuditorUser1, _ = helpers.CreateUserInSpaceRole(orgName, spaceName, "SpaceAuditor")
 			})
 
@@ -61,6 +63,8 @@ var _ = Describe("space-users command", func() {
 				Eventually(session).Should(Say(`\s+%s \(uaa\)`, spaceManagerUser))
 				Eventually(session).Should(Say("SPACE DEVELOPER"))
 				Eventually(session).Should(Say(`\s+%s \(uaa\)`, spaceDeveloperUser))
+				Eventually(session).Should(Say("SPACE SUPPORTER"))
+				Eventually(session).Should(Say(`\s+%s \(uaa\)`, spaceSupporterUser))
 				Eventually(session).Should(Say("SPACE AUDITOR"))
 				Eventually(session).Should(Say(`\s+%s \(uaa\)`, spaceAuditorUser1))
 				Eventually(session).Should(Exit(0))