-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Event Alerts Plugin version to 0.0.1 #198
Conversation
Initial Event Alerts Plugin
Signed-off-by: Jeremy Alvis <jalvis@pivotal.io>
Signed-off-by: David Timm <dtimm@pivotal.io>
Signed-off-by: Jeremy Alvis <jalvis@pivotal.io>
Initial Event Alerts Plugin
Signed-off-by: Warren Fernandes <wfernandes@pivotal.io>
Initial Event Alerts Plugin
Hey pcf-event-alerts-cibot! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/154447741 The labels on this github issue will be updated when the story is started. |
@dkoper Thanks for the feedback we created this new PR that addresses the concerns you had.
|
@wfernandes it appears that in other pull requests people are swapping out spaces for dashes in the plugin name. Is this something you'd like to do before I merge this pull request? |
@XenoPhex We just discussed and decided to not replace the spaces with dashes. |
@wfernandes FYI, it looks like the plugin repo name to install the plugin (install from plugin repo flow) is different from the plugin binary name to uninstall it. You may want to revise so they're the same. Otherwise, I was able to install and uninstall it. Install experience:
Uninstall experience:
|
@jbpivotal Thanks for the feedback. I've added a in our backlog to track this. |
No description provided.