Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Event Alerts Plugin version to 0.0.1 #198

Merged
merged 7 commits into from
Jan 19, 2018
Merged

Update Event Alerts Plugin version to 0.0.1 #198

merged 7 commits into from
Jan 19, 2018

Conversation

pcf-event-alerts-cibot
Copy link
Contributor

No description provided.

Initial Event Alerts Plugin
Signed-off-by: Jeremy Alvis <jalvis@pivotal.io>
Signed-off-by: David Timm <dtimm@pivotal.io>
Signed-off-by: Jeremy Alvis <jalvis@pivotal.io>
Initial Event Alerts Plugin
Signed-off-by: Warren Fernandes <wfernandes@pivotal.io>
Initial Event Alerts Plugin
@cfdreddbot
Copy link

Hey pcf-event-alerts-cibot!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/154447741

The labels on this github issue will be updated when the story is started.

@wfernandes
Copy link
Contributor

@dkoper Thanks for the feedback we created this new PR that addresses the concerns you had.

  • We updated the description to mention the plugin is meant for PCF
  • We updated the homepage of the plugin to point to our docs site which includes information about the CLI plugin repo.

@XenoPhex
Copy link
Contributor

@wfernandes it appears that in other pull requests people are swapping out spaces for dashes in the plugin name.

Is this something you'd like to do before I merge this pull request?

@wfernandes
Copy link
Contributor

@XenoPhex We just discussed and decided to not replace the spaces with dashes.
Thanks for checking with us though.
We hope to update the name anyways once we upgrade it from beta.

@XenoPhex XenoPhex merged commit 74c9542 into cloudfoundry:master Jan 19, 2018
@jbpivotal
Copy link

jbpivotal commented Jan 24, 2018

@wfernandes FYI, it looks like the plugin repo name to install the plugin (install from plugin repo flow) is different from the plugin binary name to uninstall it. You may want to revise so they're the same. Otherwise, I was able to install and uninstall it.

Install experience:

$ cf install-plugin "PCF Event Alerts (Beta)"
Searching CF-Community for plugin PCF Event Alerts (Beta)...
Plugin PCF Event Alerts (Beta) 0.0.1 found in: CF-Community
Attention: Plugins are binaries written by potentially untrusted authors.
Install and use plugins at your own risk.
Do you want to install the plugin PCF Event Alerts (Beta)? [yN]: y
Starting download of plugin binary from repository CF-Community...
 9.88 MiB / 9.88 MiB [=======================================================================================================================] 100.00% 1s
Installing plugin EventAlertsPlugin...
OK
Plugin EventAlertsPlugin 0.0.1 successfully installed.

Uninstall experience:

$ cf uninstall-plugin "PCF Event Alerts (Beta)"
Plugin PCF Event Alerts (Beta) does not exist.
FAILED
$ cf uninstall-plugin EventAlertsPlugin
Uninstalling plugin EventAlertsPlugin...
Thank you for using Event Alerts plugin
OK
Plugin EventAlertsPlugin 0.0.1 successfully uninstalled.

@wfernandes
Copy link
Contributor

@jbpivotal Thanks for the feedback. I've added a in our backlog to track this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants