Add clients.read permissions to CF admin user #737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/164579874 The labels on this github issue will be updated when the story is started. |
|
✅ Hey tjvman! The commit authors and yourself have already signed the CLA. |
|
Hello friend, it looks like your pull request has failed one or more of our checks. Please take a look! 👀 |
|
I have a sneaking suspicion that the failure isn't related to this PR (definitely didn't remove any ops-files) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a PR to the develop branch of cf-deployment?
Yes.
WHAT is this change about?
This change adds the
clients.readpermission to the CF admin user.WHY is this change being made (What problem is being addressed)?
The CF CLI has implemented (but not released) changes to the set-org-role and set-space-role commands that allow setting roles on clients. These changes include validation that a provided client actually exists in the UAA, which requires the logged-in user to have one of a set of specific scopes (one option is
clients.read).Please provide contextual information.
Relevant stories:
https://www.pivotaltracker.com/story/show/159967411
https://www.pivotaltracker.com/story/show/159969560
Has a cf-deployment including this change passed our cf-acceptance-tests?
How should this change be described in cf-deployment release notes?
clients.readscope has been added to the CF Admin user's permissions.Does this PR introduce a breaking change?
No.
Will this change increase the VM footprint of cf-deployment?
Does this PR make a change to an experimental or GA'd feature/component?
What is the level of urgency for publishing this change?
Tag your pair, your PM, and/or team!
@cloudfoundry/cf-cli