Make blobstore default nginx configurable #26
Merged
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* So that it doesn't conflict with gorouter Signed-off-by: Anthony Emengo <aemengo@pivotal.io>
|
Hey aemengo! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/127012923 The labels on this github issue will be updated when the story is started. |
|
Thanks for the pull request, @aemengo! This port is also used by the public endpoint of the blobstore, but because of how nginx resolves where to send requests it should not interfere with traffic to that endpoint. Also, it passes CATS. Merged! |
capi-bot
added a commit
that referenced
this pull request
Jun 22, 2023
Bump src/code.cloudfoundry.org/tps
dependabot[bot]:
Bump github.com/onsi/ginkgo/v2 from 2.9.2 to 2.11.0 (#26)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to the
capi_release. To speed up the process of reviewing your pull request please provide us with:Sets the port of the default blobstore nginx server to
blobstore.portThe blobstore conflicts with gorouter when colocated. This allows us to run them on separate ports.
masterbranchSigned-off-by: Anthony Emengo aemengo@pivotal.io