Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toggle to disable humam readable for Openstack #172

Merged

Conversation

shinji62
Copy link
Contributor

Add ops-files to desactivate humam readabl for Openstack.

This is actually needed when using openstack as cloud-provider in Kubernetes (ala Kubo).

Verified

This commit was signed with the committer’s verified signature.
TarikGul Tarik Gul
@cfdreddbot
Copy link

Hey shinji62!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@shinji62
Copy link
Contributor Author

@cppforlife

@jhiemer
Copy link

jhiemer commented Dec 28, 2017

@shinji62 wouldn't it be better to ask the OpenStack CPI team to change then separator between the name and the id into something like "-", which would keep the human readable names and also be allowed in context of DNS?

(facing the same problem as you currently).

@shinji62
Copy link
Contributor Author

@jhiemer This is not only kubo related. So if people would like to desactivate this behavior. this PR will help

@jhiemer
Copy link

jhiemer commented Dec 28, 2017

@shinji62 I am aware of that. But then it will be a much bigger problem with other deployments also relying on DNS in future, or?

@shinji62
Copy link
Contributor Author

Agree, but again this is just to desactivate it.

@dpb587-pivotal
Copy link
Contributor

🔗 Some related Slack discussion about this...

Original error message...

Unable to register node "worker/925f11f3-80af-4844-a00e-f0af521779d1" with API server: Node "worker/925f11f3-80af-4844-a00e-f0af521779d1" is invalid: metadata.name: Invalid value: "worker/925f11f3-80af-4844-a00e-f0af521779d1": a DNS-1123 subdomain must consist of lower case alphanumeric characters, '-' or '.', and must start and end with an alphanumeric character (e.g. 'example.com', regex used for validation is 'a-z0-9?(.a-z0-9?)*')

@shinji62
Copy link
Contributor Author

shinji62 commented Jan 3, 2018

@dpb587-pivotal Please see https://cloudfoundry.slack.com/archives/C0SBBBJSZ/p1514918952000286

Could be good to have this merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants