Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split destinations by commas to handle comma-delimited lists #94

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

dsabeti
Copy link
Contributor

@dsabeti dsabeti commented Apr 1, 2024

When a user of CF defines an ASG, it is usually of the form:

[
  {
    "protocol": "tcp",
    "destination": "10.0.10.0/24",
    "ports": "80,443",
    "log": true,
    "description": "Allow http and https traffic to ZoneA"
  },
 {
    "protocol": "tcp",
    "destination": "10.0.20.0/24",
    "ports": "80,443",
    "log": true,
    "description": "Allow http and https traffic to ZoneB"
  }
]

This commit will allow users to define the destinations with comma-delimited lists, allowing the previous ASG to be condensed to:

[
  {
    "protocol": "tcp",
    "destination": "10.0.10.0/24,10.0.20.0/24", 👈 🥳
    "ports": "80,443",
    "log": true,
    "description": "Allow http and https traffic to ZoneA and ZoneB"
  }
]

#186770285

Signed-off-by: Josh Russett <josh.russett@broadcom.com>
@dsabeti dsabeti requested a review from a team as a code owner April 1, 2024 22:58
Copy link
Contributor

@jrussett jrussett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@jrussett jrussett merged commit ed87f49 into main Apr 1, 2024
1 check passed
@jrussett jrussett deleted the handle-comma-delim-lists branch April 1, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants