Refactor pipelines commands into separate files, rename some options #7769
Conversation
🦋 Changeset detectedLatest commit: c70d322 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
**Pipelines is currently in closed beta, renaming these without providing aliases _should_ have no impact** Moving each of the subcommand handlers and options for each subcommand into its own file. This also renames many of the parameters to be more specific. The following parameters have been renamed: | Previous Name | New Name | | ---- | ---- | | access-key-id | r2-access-key-id | | secret-access-key | r2-secret-access-key | | transform | transform-worker | | r2 | r2-bucket | | prefix | r2-prefix | | binding | enable-worker-binding | | http | enable-http | | authentication | require-http-auth | | filename | file-template | | filepath | partition-template | Adds the following new option for `create` and `update` commands: ``` --cors-origins CORS origin allowlist for HTTP endpoint (use * for any origin) [array] ``` Closes https://jira.cfdata.org/browse/PIPE-160.
c9e676d to
e7987d4
Compare
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12795361715/npm-package-wrangler-7769You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7769/npm-package-wrangler-7769Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12795361715/npm-package-wrangler-7769 dev path/to/script.jsAdditional artifacts:cloudflare-workers-bindings-extension: wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12795361715/npm-package-cloudflare-workers-bindings-extension-7769 -O ./cloudflare-workers-bindings-extension.0.0.0-v3bc360f35.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v3bc360f35.vsixcreate-cloudflare: npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12795361715/npm-package-create-cloudflare-7769 --no-auto-update@cloudflare/kv-asset-handler: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12795361715/npm-package-cloudflare-kv-asset-handler-7769miniflare: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12795361715/npm-package-miniflare-7769@cloudflare/pages-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12795361715/npm-package-cloudflare-pages-shared-7769@cloudflare/unenv-preset: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12795361715/npm-package-cloudflare-unenv-preset-7769@cloudflare/vitest-pool-workers: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12795361715/npm-package-cloudflare-vitest-pool-workers-7769@cloudflare/workers-editor-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12795361715/npm-package-cloudflare-workers-editor-shared-7769@cloudflare/workers-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12795361715/npm-package-cloudflare-workers-shared-7769@cloudflare/workflows-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12795361715/npm-package-cloudflare-workflows-shared-7769Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
| import type { CommonYargsOptions } from "../../yargs-types"; | ||
| import type { ArgumentsCamelCase } from "yargs"; | ||
|
|
||
| export async function listPipelinesHandler( |
There was a problem hiding this comment.
shouldn't this fn call await printWranglerBanner(); as well?
There was a problem hiding this comment.
I am not sure, I copied it directly from https://github.com/cloudflare/workers-sdk/pull/7769/files#diff-bd3457733e5c7c3cdc0ea531bc35fc5858ec21ea84e1f65a11bee0f222efd727L330-L347.
Should all commands call printWranglerBanner?
Pipelines is currently in closed beta, renaming these without providing aliases should have limited to zero impact
Moving each of the subcommand handlers and options for each subcommand into its own file. This also renames many of the parameters to be more specific.
The following parameters have been renamed:
Adds the following new option for
createandupdatecommands:Closes https://jira.cfdata.org/browse/PIPE-160.