chore: update wrangler versions in templates #7742

threepointone · 2025-01-12T19:44:20Z

We should probably automate this, but doing it manually for now since it's so behind.

Fixes #0000

Tests
- TODO (before merge)
- Tests included
- Tests not necessary because: no functional change
E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
- I don't know
- Required
- Not required because: no functional change
Public documentation
- TODO (before merge)
- Cloudflare docs PR(s):
- Documentation not necessary because: no functional change

changeset-bot · 2025-01-12T19:44:24Z

🦋 Changeset detected

Latest commit: 8836e90

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
create-cloudflare	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2025-01-12T19:47:01Z

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12736662831/npm-package-wrangler-7742

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7742/npm-package-wrangler-7742

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12736662831/npm-package-wrangler-7742 dev path/to/script.js

Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12736662831/npm-package-cloudflare-workers-bindings-extension-7742 -O ./cloudflare-workers-bindings-extension.0.0.0-v83a103592.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v83a103592.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12736662831/npm-package-create-cloudflare-7742 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12736662831/npm-package-cloudflare-kv-asset-handler-7742

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12736662831/npm-package-miniflare-7742

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12736662831/npm-package-cloudflare-pages-shared-7742

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12736662831/npm-package-cloudflare-unenv-preset-7742

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12736662831/npm-package-cloudflare-vitest-pool-workers-7742

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12736662831/npm-package-cloudflare-workers-editor-shared-7742

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12736662831/npm-package-cloudflare-workers-shared-7742

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12736662831/npm-package-cloudflare-workflows-shared-7742

Note that these links will no longer work once the GitHub Actions artifact expires.

wrangler@3.101.0 includes the following runtime dependencies:

Package	Constraint	Resolved
`miniflare`	workspace:*	3.20241230.1
`workerd`	1.20241230.0	1.20241230.0
`workerd --version`	1.20241230.0	2024-12-30

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

threepointone · 2025-01-12T20:04:59Z

packages/create-cloudflare/templates/hello-world-durable-object/ts/src/index.ts

@@ -14,7 +14,7 @@ import { DurableObject } from "cloudflare:workers";
 */

 /** A Durable Object's behavior is defined in an exported Javascript class */
-export class MyDurableObject extends DurableObject {
+export class MyDurableObject extends DurableObject<Env> {


also added this fix here

Is this correct? In workers-types DurableObject has no type param.

Hmm... interestingly the @cloudflare/workers-types library has two files of note: index.ts and index.d.ts.
The latter contains export abstract class DurableObject<Env = unknown> while the former does not.

But in my setup it appears that VS Code is picking up the index.ts and so erroring if I provide a type param.

Doh! I see now. This is imported from the cloudflare:workers module, which is what brings in this class.

petebacondarwin · 2025-01-13T07:32:41Z

...ate-cloudflare/templates-experimental/hello-world-durable-object-with-assets/js/package.json

@@ -8,6 +8,6 @@
 		"start": "wrangler dev"
 	},
 	"devDependencies": {
-		"wrangler": "^3.60.3"
+		"wrangler": "^3.101.0"


Just to be clear, for my sake, I believe that updating these has no practical effect, since the ^ will cause the most recent Wrangler v3 minor version to be installed anyway. Right?

The only reason to worry about updating these would be if there was a new feature in a minor that the template relied upon.

Considering it more of a cleanliness thing really. Looks bad if our own official templates don't point to the latest version. Ideally this would be automated.

petebacondarwin · 2025-01-13T07:41:14Z

packages/create-cloudflare/templates/hello-world-durable-object/ts/src/index.ts

@@ -14,7 +14,7 @@ import { DurableObject } from "cloudflare:workers";
 */

 /** A Durable Object's behavior is defined in an exported Javascript class */
-export class MyDurableObject extends DurableObject {
+export class MyDurableObject extends DurableObject<Env> {


Is this correct? In workers-types DurableObject has no type param.

Hmm... interestingly the @cloudflare/workers-types library has two files of note: index.ts and index.d.ts.
The latter contains export abstract class DurableObject<Env = unknown> while the former does not.

But in my setup it appears that VS Code is picking up the index.ts and so erroring if I provide a type param.

petebacondarwin · 2025-01-13T07:55:22Z

packages/create-cloudflare/templates/hello-world-durable-object/ts/src/index.ts

@@ -14,7 +14,7 @@ import { DurableObject } from "cloudflare:workers";
 */

 /** A Durable Object's behavior is defined in an exported Javascript class */
-export class MyDurableObject extends DurableObject {
+export class MyDurableObject extends DurableObject<Env> {


Doh! I see now. This is imported from the cloudflare:workers module, which is what brings in this class.

threepointone requested review from a team as code owners January 12, 2025 19:44

chore: update wrangler versions in templates

8836e90

threepointone force-pushed the update-template-wrangler-versions branch from d2c8281 to 8836e90 Compare January 12, 2025 20:04

threepointone commented Jan 12, 2025

View reviewed changes

petebacondarwin reviewed Jan 13, 2025

View reviewed changes

petebacondarwin approved these changes Jan 13, 2025

View reviewed changes

threepointone merged commit 8fb0f25 into main Jan 13, 2025
29 checks passed

threepointone deleted the update-template-wrangler-versions branch January 13, 2025 12:51

workers-devprod mentioned this pull request Jan 13, 2025

Version Packages #7716

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: update wrangler versions in templates #7742

chore: update wrangler versions in templates #7742

threepointone commented Jan 12, 2025

changeset-bot bot commented Jan 12, 2025 •

edited

Loading

github-actions bot commented Jan 12, 2025 •

edited

Loading

threepointone Jan 12, 2025

petebacondarwin Jan 13, 2025 •

edited

Loading

petebacondarwin Jan 13, 2025

petebacondarwin Jan 13, 2025

threepointone Jan 13, 2025

petebacondarwin Jan 13, 2025 •

edited

Loading

petebacondarwin Jan 13, 2025

chore: update wrangler versions in templates #7742

chore: update wrangler versions in templates #7742

Conversation

threepointone commented Jan 12, 2025

changeset-bot bot commented Jan 12, 2025 • edited Loading

🦋 Changeset detected

github-actions bot commented Jan 12, 2025 • edited Loading

threepointone Jan 12, 2025

Choose a reason for hiding this comment

petebacondarwin Jan 13, 2025 • edited Loading

Choose a reason for hiding this comment

petebacondarwin Jan 13, 2025

Choose a reason for hiding this comment

petebacondarwin Jan 13, 2025

Choose a reason for hiding this comment

threepointone Jan 13, 2025

Choose a reason for hiding this comment

petebacondarwin Jan 13, 2025 • edited Loading

Choose a reason for hiding this comment

petebacondarwin Jan 13, 2025

Choose a reason for hiding this comment

changeset-bot bot commented Jan 12, 2025 •

edited

Loading

github-actions bot commented Jan 12, 2025 •

edited

Loading

petebacondarwin Jan 13, 2025 •

edited

Loading

petebacondarwin Jan 13, 2025 •

edited

Loading