-
Notifications
You must be signed in to change notification settings - Fork 758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bundle & pin Wrangler dependencies #7737
Conversation
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12748809469/npm-package-wrangler-7737 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7737/npm-package-wrangler-7737 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12748809469/npm-package-wrangler-7737 dev path/to/script.js Additional artifacts:cloudflare-workers-bindings-extension: wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12748809469/npm-package-cloudflare-workers-bindings-extension-7737 -O ./cloudflare-workers-bindings-extension.0.0.0-v1cfc8bfd8.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v1cfc8bfd8.vsix create-cloudflare: npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12748809469/npm-package-create-cloudflare-7737 --no-auto-update @cloudflare/kv-asset-handler: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12748809469/npm-package-cloudflare-kv-asset-handler-7737 miniflare: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12748809469/npm-package-miniflare-7737 @cloudflare/pages-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12748809469/npm-package-cloudflare-pages-shared-7737 @cloudflare/unenv-preset: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12748809469/npm-package-cloudflare-unenv-preset-7737 @cloudflare/vitest-pool-workers: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12748809469/npm-package-cloudflare-vitest-pool-workers-7737 @cloudflare/workers-editor-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12748809469/npm-package-cloudflare-workers-editor-shared-7737 @cloudflare/workers-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12748809469/npm-package-cloudflare-workers-shared-7737 @cloudflare/workflows-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12748809469/npm-package-cloudflare-workflows-shared-7737 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for cleaning this up
This modifies Wrangler's dependencies to try and prevent breakage from issues like paulmillr/readdirp#203, where a transitive dependency upgrade broke new Wrangler installs.
Additional bundled dependencies:
fsevents
selfsigned
source-map
chokidar
I've also pinned all dependencies of Wrangler to the version we were using, and moved some stray bundled dependencies to dev deps (they were already being bundled in Wrangler, so this was just causing users installing Wrangler to have to install them unecessarily).
Additionally,
nanoid
was removed and replaced withcrypto.randomUUID()