Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle & pin Wrangler dependencies #7737

Merged
merged 3 commits into from
Jan 13, 2025
Merged

Bundle & pin Wrangler dependencies #7737

merged 3 commits into from
Jan 13, 2025

Conversation

penalosa
Copy link
Contributor

@penalosa penalosa commented Jan 11, 2025

This modifies Wrangler's dependencies to try and prevent breakage from issues like paulmillr/readdirp#203, where a transitive dependency upgrade broke new Wrangler installs.

Additional bundled dependencies:

  • fsevents
  • selfsigned
  • source-map
  • chokidar

I've also pinned all dependencies of Wrangler to the version we were using, and moved some stray bundled dependencies to dev deps (they were already being bundled in Wrangler, so this was just causing users installing Wrangler to have to install them unecessarily).

Additionally, nanoid was removed and replaced with crypto.randomUUID()


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: no functionality change, so should be covered by existing tests
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: internal refactor

@penalosa penalosa requested a review from a team as a code owner January 11, 2025 18:05
Copy link

changeset-bot bot commented Jan 11, 2025

⚠️ No Changeset found

Latest commit: 1f44cb8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 11, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12748809469/npm-package-wrangler-7737

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7737/npm-package-wrangler-7737

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12748809469/npm-package-wrangler-7737 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12748809469/npm-package-cloudflare-workers-bindings-extension-7737 -O ./cloudflare-workers-bindings-extension.0.0.0-v1cfc8bfd8.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v1cfc8bfd8.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12748809469/npm-package-create-cloudflare-7737 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12748809469/npm-package-cloudflare-kv-asset-handler-7737

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12748809469/npm-package-miniflare-7737

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12748809469/npm-package-cloudflare-pages-shared-7737

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12748809469/npm-package-cloudflare-unenv-preset-7737

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12748809469/npm-package-cloudflare-vitest-pool-workers-7737

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12748809469/npm-package-cloudflare-workers-editor-shared-7737

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12748809469/npm-package-cloudflare-workers-shared-7737

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12748809469/npm-package-cloudflare-workflows-shared-7737

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.101.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241230.1
workerd 1.20241230.0 1.20241230.0
workerd --version 1.20241230.0 2024-12-30

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

packages/wrangler/scripts/deps.ts Outdated Show resolved Hide resolved
@petebacondarwin petebacondarwin added skip-pr-description-validation Skip validation of the required PR description format no-changeset-required labels Jan 13, 2025
@penalosa penalosa requested a review from a team as a code owner January 13, 2025 13:56
@penalosa penalosa changed the title Bundle chokidar Bundle & pin Wrangler dependencies Jan 13, 2025
@penalosa penalosa added e2e Run e2e tests on a PR and removed skip-pr-description-validation Skip validation of the required PR description format labels Jan 13, 2025
Copy link
Contributor

@CarmenPopoviciu CarmenPopoviciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for cleaning this up ♥️

@penalosa penalosa merged commit 336cc48 into main Jan 13, 2025
40 of 42 checks passed
@penalosa penalosa deleted the penalosa/bundle-chokidar branch January 13, 2025 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e tests on a PR no-changeset-required
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants