Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update workflow default node version #7649

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

edmundhung
Copy link
Member

Fixes #7648

This updates the default node version to the latest patch version of node 18, which is required by our Nuxt c3 tests.


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: ci update
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: ci update

@edmundhung edmundhung requested a review from a team as a code owner December 30, 2024 15:38
Copy link

changeset-bot bot commented Dec 30, 2024

⚠️ No Changeset found

Latest commit: d8a8446

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12548670863/npm-package-wrangler-7649

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7649/npm-package-wrangler-7649

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12548670863/npm-package-wrangler-7649 dev path/to/script.js
Additional artifacts:
wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12548670863/npm-package-cloudflare-workers-bindings-extension-7649 -O ./cloudflare-workers-bindings-extension.0.0.0-v979371d62.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v979371d62.vsix
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12548670863/npm-package-create-cloudflare-7649 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12548670863/npm-package-cloudflare-kv-asset-handler-7649
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12548670863/npm-package-miniflare-7649
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12548670863/npm-package-cloudflare-pages-shared-7649
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12548670863/npm-package-cloudflare-unenv-preset-7649
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12548670863/npm-package-cloudflare-vitest-pool-workers-7649
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12548670863/npm-package-cloudflare-workers-editor-shared-7649
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12548670863/npm-package-cloudflare-workers-shared-7649
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12548670863/npm-package-cloudflare-workflows-shared-7649

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.99.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241218.0
workerd 1.20241218.0 1.20241218.0
workerd --version 1.20241218.0 2024-12-18

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@edmundhung edmundhung added no-changeset-required e2e Run e2e tests on a PR labels Dec 30, 2024
Copy link
Member

@dario-piotrowicz dario-piotrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 😄 , thanks @edmundhung 🙏

@edmundhung edmundhung changed the title chore: update default node version when install dependencies chore: update workflow default node version Dec 30, 2024
@edmundhung edmundhung merged commit f785f12 into main Dec 30, 2024
42 of 44 checks passed
@edmundhung edmundhung deleted the edmundhung/update-default-node-version branch December 30, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e tests on a PR no-changeset-required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants