Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(wrangler): update unenv dependency version #7614

Merged
merged 1 commit into from
Dec 23, 2024
Merged

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Dec 22, 2024

This is testing the fix in unenv for module resolution.
The bug made use revert using the unenv module resolution in the nodejs hybrid plugin last week.

Note that module resolution has not been plugged in again in this PR. We are only pulling the fix and testing it. The module resolution PRs will be re-integrated as follow up PRs.

/cc @pi0


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: no user facing changes

@vicb vicb requested a review from a team as a code owner December 22, 2024 18:41
Copy link

changeset-bot bot commented Dec 22, 2024

🦋 Changeset detected

Latest commit: 0418464

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vicb vicb added the e2e Run e2e tests on a PR label Dec 22, 2024
@vicb vicb requested a review from petebacondarwin December 22, 2024 18:41
Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12456785104/npm-package-wrangler-7614

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7614/npm-package-wrangler-7614

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12456785104/npm-package-wrangler-7614 dev path/to/script.js
Additional artifacts:
wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12456785104/npm-package-cloudflare-workers-bindings-extension-7614 -O ./cloudflare-workers-bindings-extension.0.0.0-va98fe7ca3.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-va98fe7ca3.vsix
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12456785104/npm-package-create-cloudflare-7614 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12456785104/npm-package-cloudflare-kv-asset-handler-7614
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12456785104/npm-package-miniflare-7614
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12456785104/npm-package-cloudflare-pages-shared-7614
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12456785104/npm-package-cloudflare-unenv-preset-7614
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12456785104/npm-package-cloudflare-vitest-pool-workers-7614
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12456785104/npm-package-cloudflare-workers-editor-shared-7614
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12456785104/npm-package-cloudflare-workers-shared-7614
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12456785104/npm-package-cloudflare-workflows-shared-7614

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.99.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241218.0
workerd 1.20241218.0 1.20241218.0
workerd --version 1.20241218.0 2024-12-18

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@vicb vicb merged commit 8abb43f into main Dec 23, 2024
32 of 37 checks passed
@vicb vicb deleted the unenv/resolve-tests branch December 23, 2024 09:21
@vicb
Copy link
Contributor Author

vicb commented Dec 23, 2024

Thanks Pete!

@petebacondarwin
Copy link
Contributor

Oh it looks like there were valid C3 e2e errors for Open Next...

@vicb
Copy link
Contributor Author

vicb commented Dec 23, 2024

Oh do you mean the C3 "experimental" tests ?
I am not sure what they are and have never seen them green!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e tests on a PR
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants