Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(workers-shared): Dummy workers-shared version bump #7598

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

CarmenPopoviciu
Copy link
Contributor

@CarmenPopoviciu CarmenPopoviciu commented Dec 19, 2024

The Router Worker and Asset Worker of workers-shared are currently in a weird state that prevents us to redeploy them. The current versions of these workers are developer modified due to adding secrets. We want a CI controlled version to safely use these secrets.

This PR performs a dummy workers-shared version bump to unlock us from this blocked state.

Fixes #000


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: dummy version bump
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: dummy version bump
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: dummy version bump

Copy link

changeset-bot bot commented Dec 19, 2024

🦋 Changeset detected

Latest commit: a07a5b5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudflare/workers-shared Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

The Router Worker and Asset Worker of `workers-shared` are
currently in a weird state that prevents us to redeploy them.
This commit performs a dummy `workers-shared` version bump
to unlock us from this blocked state.
@CarmenPopoviciu CarmenPopoviciu force-pushed the carmen/bump-workers-shared branch from c5f50ca to a07a5b5 Compare December 19, 2024 15:51
Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12416141620/npm-package-wrangler-7598

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7598/npm-package-wrangler-7598

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12416141620/npm-package-wrangler-7598 dev path/to/script.js
Additional artifacts:
wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12416141620/npm-package-cloudflare-workers-bindings-extension-7598 -O ./cloudflare-workers-bindings-extension.0.0.0-v92861b48d.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v92861b48d.vsix
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12416141620/npm-package-create-cloudflare-7598 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12416141620/npm-package-cloudflare-kv-asset-handler-7598
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12416141620/npm-package-miniflare-7598
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12416141620/npm-package-cloudflare-pages-shared-7598
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12416141620/npm-package-cloudflare-unenv-preset-7598
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12416141620/npm-package-cloudflare-vitest-pool-workers-7598
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12416141620/npm-package-cloudflare-workers-editor-shared-7598
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12416141620/npm-package-cloudflare-workers-shared-7598
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12416141620/npm-package-cloudflare-workflows-shared-7598

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.98.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241205.0
workerd 1.20241218.0 1.20241218.0
workerd --version 1.20241218.0 2024-12-18

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@CarmenPopoviciu CarmenPopoviciu merged commit 178fd01 into main Dec 19, 2024
29 checks passed
@CarmenPopoviciu CarmenPopoviciu deleted the carmen/bump-workers-shared branch December 19, 2024 16:26
emily-shen pushed a commit that referenced this pull request Dec 19, 2024
The Router Worker and Asset Worker of `workers-shared` are
currently in a weird state that prevents us to redeploy them.
This commit performs a dummy `workers-shared` version bump
to unlock us from this blocked state.
penalosa pushed a commit that referenced this pull request Jan 10, 2025
The Router Worker and Asset Worker of `workers-shared` are
currently in a weird state that prevents us to redeploy them.
This commit performs a dummy `workers-shared` version bump
to unlock us from this blocked state.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants