Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(wrangler): Fix failing e2e tests #7585

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Conversation

CarmenPopoviciu
Copy link
Contributor

@CarmenPopoviciu CarmenPopoviciu commented Dec 18, 2024

This commit fixed some e2e tests that started failing after #7476

Fixes #000.


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: e2e tests fix

@CarmenPopoviciu CarmenPopoviciu requested a review from a team as a code owner December 18, 2024 13:47
Copy link

changeset-bot bot commented Dec 18, 2024

⚠️ No Changeset found

Latest commit: 647d610

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@workers-devprod workers-devprod added the e2e Run e2e tests on a PR label Dec 18, 2024
This commit fixed some e2e tests that started failing after #7476
Copy link
Contributor

github-actions bot commented Dec 18, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12394409134/npm-package-wrangler-7585

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7585/npm-package-wrangler-7585

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12394409134/npm-package-wrangler-7585 dev path/to/script.js
Additional artifacts:
wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12394409134/npm-package-cloudflare-workers-bindings-extension-7585 -O ./cloudflare-workers-bindings-extension.0.0.0-v1c02a197b.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v1c02a197b.vsix
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12394409134/npm-package-create-cloudflare-7585 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12394409134/npm-package-cloudflare-kv-asset-handler-7585
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12394409134/npm-package-miniflare-7585
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12394409134/npm-package-cloudflare-pages-shared-7585
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12394409134/npm-package-cloudflare-unenv-preset-7585
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12394409134/npm-package-cloudflare-vitest-pool-workers-7585
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12394409134/npm-package-cloudflare-workers-editor-shared-7585
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12394409134/npm-package-cloudflare-workers-shared-7585
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12394409134/npm-package-cloudflare-workflows-shared-7585

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.97.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241205.0
workerd 1.20241205.0 1.20241205.0
workerd --version 1.20241205.0 2024-12-05

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@CarmenPopoviciu CarmenPopoviciu merged commit c74195c into main Dec 18, 2024
35 of 39 checks passed
@CarmenPopoviciu CarmenPopoviciu deleted the carmen/fix-e2e branch December 18, 2024 15:16
penalosa pushed a commit that referenced this pull request Jan 10, 2025
This commit fixed some e2e tests that started failing after #7476
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e tests on a PR no-changeset-required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants