Remove defaults for batch-max-* pipeline parameters and define value ranges
#7576
+17
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 65b67ce The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12677414917/npm-package-wrangler-7576You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7576/npm-package-wrangler-7576Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12677414917/npm-package-wrangler-7576 dev path/to/script.jsAdditional artifacts:wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12677414917/npm-package-cloudflare-workers-bindings-extension-7576 -O ./cloudflare-workers-bindings-extension.0.0.0-vfe8b3a722.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-vfe8b3a722.vsixnpx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12677414917/npm-package-create-cloudflare-7576 --no-auto-updatenpm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12677414917/npm-package-cloudflare-kv-asset-handler-7576npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12677414917/npm-package-miniflare-7576npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12677414917/npm-package-cloudflare-pages-shared-7576npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12677414917/npm-package-cloudflare-unenv-preset-7576npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12677414917/npm-package-cloudflare-vitest-pool-workers-7576npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12677414917/npm-package-cloudflare-workers-editor-shared-7576npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12677414917/npm-package-cloudflare-workers-shared-7576npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12677414917/npm-package-cloudflare-workflows-shared-7576Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
edmundhung
reviewed
Jan 6, 2025
| type: "number", | ||
| default: 10, |
There was a problem hiding this comment.
I see that we mentioned the default value in the description already. Is this the same default value we have on the API side? That's why this is a non-breaking change?
There was a problem hiding this comment.
Yeah, 10 MB is the current default on the API side. Regarding breaking changes, this is currently in private beta and changes like this are expected.
There was a problem hiding this comment.
The defaults are still being determined, so I removed here and will instead only set them on the API side.
fa11ba7 to
0a33de4
Compare
Closes https://jira.cfdata.org/browse/PIPE-152 The defaults are currently in flux and changing as we determine what makes sense for the system. To support these changing values, remove the defaults from the client as they will be set by the API. The values used to create the pipeline are visible to user when doing `wrangler pipeline show <name>`. Create three-chefs-bathe.md
0a33de4 to
ea966a8
Compare
penalosa
approved these changes
Jan 8, 2025
ea966a8 to
65b67ce
Compare
batch-max-* pipeline parametersbatch-max-* pipeline parameters and define value ranges
Merged
penalosa
pushed a commit
that referenced
this pull request
Jan 10, 2025
…e ranges (#7576) * Update help message for `batch-max-*` pipeline parameters Closes https://jira.cfdata.org/browse/PIPE-152 The defaults are currently in flux and changing as we determine what makes sense for the system. To support these changing values, remove the defaults from the client as they will be set by the API. The values used to create the pipeline are visible to user when doing `wrangler pipeline show <name>`. Create three-chefs-bathe.md * Covert MB to bytes for the API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://jira.cfdata.org/browse/PIPE-152
Describe your change...