Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed port in playwright config file #7428

Merged
merged 3 commits into from
Dec 6, 2024
Merged

Conversation

Oreoezi
Copy link
Contributor

@Oreoezi Oreoezi commented Dec 3, 2024

One issue that I had creating a Sveltekit project using create-cloudflare was the fact that the playwright configuration file still had its port set to the default of 4173, which would cause the test to hang. I could either change the webServer.command property to override the default port that miniflare uses or to change the port to 8788 (which is what I chose).

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: The changes are relatively simple.
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: The changes are relatively simple.
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: It does not change in any way the user experience.

@Oreoezi Oreoezi requested review from a team as code owners December 3, 2024 17:05
Copy link

changeset-bot bot commented Dec 3, 2024

🦋 Changeset detected

Latest commit: 50dfca1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 4, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12186506538/npm-package-wrangler-7428

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7428/npm-package-wrangler-7428

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12186506538/npm-package-wrangler-7428 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12186506538/npm-package-create-cloudflare-7428 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12186506538/npm-package-cloudflare-kv-asset-handler-7428
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12186506538/npm-package-miniflare-7428
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12186506538/npm-package-cloudflare-pages-shared-7428
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12186506538/npm-package-cloudflare-vitest-pool-workers-7428
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12186506538/npm-package-cloudflare-workers-editor-shared-7428
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12186506538/npm-package-cloudflare-workers-shared-7428
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12186506538/npm-package-cloudflare-workflows-shared-7428

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.92.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241106.2
workerd 1.20241106.2 1.20241106.2
workerd --version 1.20241106.2 2024-11-06

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link
Contributor

@penalosa penalosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably more trouble than it's worth to add a test here, but I've validated it manually

@penalosa
Copy link
Contributor

penalosa commented Dec 5, 2024

@Oreoezi could you fix the formatting issues here? Running pnpm prettify should be enough

@Oreoezi
Copy link
Contributor Author

Oreoezi commented Dec 5, 2024

@penalosa I ran prettier. lmk if that fixed all the formatting issues.

@penalosa penalosa merged commit f463dd2 into cloudflare:main Dec 6, 2024
26 checks passed
@workers-devprod workers-devprod mentioned this pull request Dec 6, 2024
@workers-devprod workers-devprod added the contribution [Holopin] Recognizes an open-source contribution, big or small label Dec 6, 2024
Copy link

holopin-bot bot commented Dec 6, 2024

Congratulations @Oreoezi, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cm4c2ez2t122090clbn1biv6ge

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution [Holopin] Recognizes an open-source contribution, big or small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants