-
Notifications
You must be signed in to change notification settings - Fork 762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed port in playwright config file #7428
Conversation
🦋 Changeset detectedLatest commit: 50dfca1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12186506538/npm-package-wrangler-7428 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7428/npm-package-wrangler-7428 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12186506538/npm-package-wrangler-7428 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12186506538/npm-package-create-cloudflare-7428 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12186506538/npm-package-cloudflare-kv-asset-handler-7428 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12186506538/npm-package-miniflare-7428 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12186506538/npm-package-cloudflare-pages-shared-7428 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12186506538/npm-package-cloudflare-vitest-pool-workers-7428 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12186506538/npm-package-cloudflare-workers-editor-shared-7428 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12186506538/npm-package-cloudflare-workers-shared-7428 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12186506538/npm-package-cloudflare-workflows-shared-7428 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably more trouble than it's worth to add a test here, but I've validated it manually
@Oreoezi could you fix the formatting issues here? Running |
@penalosa I ran prettier. lmk if that fixed all the formatting issues. |
Congratulations @Oreoezi, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cm4c2ez2t122090clbn1biv6ge This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
One issue that I had creating a Sveltekit project using create-cloudflare was the fact that the playwright configuration file still had its port set to the default of 4173, which would cause the test to hang. I could either change the
webServer.command
property to override the default port that miniflare uses or to change the port to 8788 (which is what I chose).