Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove duplicate PagesConfigFields interface #7363

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

petebacondarwin
Copy link
Contributor

Fixes #0000

Simple refactor.


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: simple refactor
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: simple refactor
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: simple refactor

@petebacondarwin petebacondarwin requested a review from a team as a code owner November 27, 2024 13:09
Copy link

changeset-bot bot commented Nov 27, 2024

⚠️ No Changeset found

Latest commit: 19d9946

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12050973219/npm-package-wrangler-7363

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7363/npm-package-wrangler-7363

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12050973219/npm-package-wrangler-7363 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12050973219/npm-package-create-cloudflare-7363 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12050973219/npm-package-cloudflare-kv-asset-handler-7363
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12050973219/npm-package-miniflare-7363
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12050973219/npm-package-cloudflare-pages-shared-7363
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12050973219/npm-package-cloudflare-vitest-pool-workers-7363
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12050973219/npm-package-cloudflare-workers-editor-shared-7363
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12050973219/npm-package-cloudflare-workers-shared-7363
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12050973219/npm-package-cloudflare-workflows-shared-7363

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.91.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241106.1
workerd 1.20241106.1 1.20241106.1
workerd --version 1.20241106.1 2024-11-06

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@petebacondarwin petebacondarwin merged commit 8009ab8 into main Nov 27, 2024
35 of 36 checks passed
@petebacondarwin petebacondarwin deleted the pbd/remove-duplicate-code branch November 27, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants