Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unrevert "Add serve_directly option to assets configuration (#7316)" #7355

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

emily-shen
Copy link
Contributor

@emily-shen emily-shen commented Nov 26, 2024

unreverts #7316

@emily-shen emily-shen requested review from a team as code owners November 26, 2024 19:23
Copy link

changeset-bot bot commented Nov 26, 2024

🦋 Changeset detected

Latest commit: 32e7ba1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Minor
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@emily-shen emily-shen added no-changeset-required skip-pr-description-validation Skip validation of the required PR description format and removed no-changeset-required labels Nov 26, 2024
Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12037615668/npm-package-wrangler-7355

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7355/npm-package-wrangler-7355

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12037615668/npm-package-wrangler-7355 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12037615668/npm-package-create-cloudflare-7355 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12037615668/npm-package-cloudflare-kv-asset-handler-7355
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12037615668/npm-package-miniflare-7355
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12037615668/npm-package-cloudflare-pages-shared-7355
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12037615668/npm-package-cloudflare-vitest-pool-workers-7355
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12037615668/npm-package-cloudflare-workers-editor-shared-7355
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12037615668/npm-package-cloudflare-workers-shared-7355
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12037615668/npm-package-cloudflare-workflows-shared-7355

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.90.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241106.1
workerd 1.20241106.1 1.20241106.1
workerd --version 1.20241106.1 2024-11-06

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@emily-shen emily-shen merged commit 5928e8c into main Nov 27, 2024
43 of 47 checks passed
@emily-shen emily-shen deleted the revert-7351-revert-7316 branch November 27, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-pr-description-validation Skip validation of the required PR description format
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants