Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove PR trigger for semgrep #7309

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Conversation

jacobbednarz
Copy link
Member

semgrep is slow and triggering this on all PR events is clogging the queue.

semgrep is slow and triggering this on all PR events is clogging the queue.
@jacobbednarz jacobbednarz requested a review from a team as a code owner November 21, 2024 01:47
Copy link

changeset-bot bot commented Nov 21, 2024

⚠️ No Changeset found

Latest commit: 5dc2893

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jacobbednarz
Copy link
Member Author

cc @hrushikeshdeshpande

Copy link
Contributor

github-actions bot commented Nov 21, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12149282797/npm-package-wrangler-7309

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7309/npm-package-wrangler-7309

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12149282797/npm-package-wrangler-7309 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12149282797/npm-package-create-cloudflare-7309 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12149282797/npm-package-cloudflare-kv-asset-handler-7309
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12149282797/npm-package-miniflare-7309
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12149282797/npm-package-cloudflare-pages-shared-7309
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12149282797/npm-package-cloudflare-vitest-pool-workers-7309
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12149282797/npm-package-cloudflare-workers-editor-shared-7309
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12149282797/npm-package-cloudflare-workers-shared-7309
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12149282797/npm-package-cloudflare-workflows-shared-7309

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.91.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241106.1
workerd 1.20241106.1 1.20241106.1
workerd --version 1.20241106.1 2024-11-06

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@penalosa
Copy link
Contributor

penalosa commented Dec 3, 2024

Closing for now, since Semgrep runs on PRs is only a few minutes: https://github.com/cloudflare/workers-sdk/actions/runs/12088429210/job/33711923769?pr=7392

@penalosa penalosa closed this Dec 3, 2024
@jacobbednarz
Copy link
Member Author

@penalosa the happy path isn't the issue here. it's when a handful of PRs are raised and we concurrency limits which are org wide and will impact other GitHub Action runners outside of just this repository. as they all share the concurrency limit, we need to do this for all active repositories.

@penalosa
Copy link
Contributor

penalosa commented Dec 3, 2024

@jacobbednarz Is semgrep the main culprit here? This repo runs a lot of actions on each PR anyway. Or is the concurrency per workflow?

@jacobbednarz
Copy link
Member Author

semgrep has been large contributing factor given the slowness of the AST checking it performs within some of the rules on larger repositories and the frequency it has been invoked. we've gone through and removed it for pushes, merges and PR events to prevent clogging the queue and stopping more critical GitHub Actions. without actioning this, it may impact the ability for you to do releases.

@penalosa penalosa reopened this Dec 3, 2024
@penalosa penalosa added the skip-pr-description-validation Skip validation of the required PR description format label Dec 3, 2024
@penalosa
Copy link
Contributor

penalosa commented Dec 4, 2024

As discussed internally, I've removed semgrep as a required check

@penalosa penalosa merged commit 4e571fd into cloudflare:main Dec 4, 2024
58 of 60 checks passed
penalosa pushed a commit that referenced this pull request Jan 10, 2025
semgrep is slow and triggering this on all PR events is clogging the queue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-pr-description-validation Skip validation of the required PR description format
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants