-
Notifications
You must be signed in to change notification settings - Fork 762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: remove PR trigger for semgrep #7309
Conversation
semgrep is slow and triggering this on all PR events is clogging the queue.
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12149282797/npm-package-wrangler-7309 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7309/npm-package-wrangler-7309 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12149282797/npm-package-wrangler-7309 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12149282797/npm-package-create-cloudflare-7309 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12149282797/npm-package-cloudflare-kv-asset-handler-7309 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12149282797/npm-package-miniflare-7309 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12149282797/npm-package-cloudflare-pages-shared-7309 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12149282797/npm-package-cloudflare-vitest-pool-workers-7309 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12149282797/npm-package-cloudflare-workers-editor-shared-7309 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12149282797/npm-package-cloudflare-workers-shared-7309 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12149282797/npm-package-cloudflare-workflows-shared-7309 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
Closing for now, since Semgrep runs on PRs is only a few minutes: https://github.com/cloudflare/workers-sdk/actions/runs/12088429210/job/33711923769?pr=7392 |
@penalosa the happy path isn't the issue here. it's when a handful of PRs are raised and we concurrency limits which are org wide and will impact other GitHub Action runners outside of just this repository. as they all share the concurrency limit, we need to do this for all active repositories. |
@jacobbednarz Is semgrep the main culprit here? This repo runs a lot of actions on each PR anyway. Or is the concurrency per workflow? |
semgrep has been large contributing factor given the slowness of the AST checking it performs within some of the rules on larger repositories and the frequency it has been invoked. we've gone through and removed it for pushes, merges and PR events to prevent clogging the queue and stopping more critical GitHub Actions. without actioning this, it may impact the ability for you to do releases. |
As discussed internally, I've removed semgrep as a required check |
semgrep is slow and triggering this on all PR events is clogging the queue.
semgrep is slow and triggering this on all PR events is clogging the queue.