Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: defineCommand refactor for wrangler dev #7249

Merged
merged 6 commits into from
Nov 15, 2024
Merged

chore: defineCommand refactor for wrangler dev #7249

merged 6 commits into from
Nov 15, 2024

Conversation

emily-shen
Copy link
Contributor

related #6655

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: no behaviour change, just needs to pass existing
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: internal refactor

@emily-shen emily-shen requested a review from a team as a code owner November 13, 2024 12:17
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 13, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 871dab7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@emily-shen emily-shen added the e2e Run e2e tests on a PR label Nov 13, 2024
@emily-shen emily-shen marked this pull request as draft November 13, 2024 12:25
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 13, 2024 •
edited
Loading

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11854405899/npm-package-wrangler-7249

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7249/npm-package-wrangler-7249

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11854405899/npm-package-wrangler-7249 dev path/to/script.js
Additional artifacts: 
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11854405899/npm-package-create-cloudflare-7249 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11854405899/npm-package-cloudflare-kv-asset-handler-7249
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11854405899/npm-package-miniflare-7249
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11854405899/npm-package-cloudflare-pages-shared-7249
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11854405899/npm-package-cloudflare-vitest-pool-workers-7249
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11854405899/npm-package-cloudflare-workers-editor-shared-7249
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11854405899/npm-package-cloudflare-workers-shared-7249
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11854405899/npm-package-cloudflare-workflows-shared-7249

Note that these links will no longer work once the GitHub Actions artifact expires.

wrangler@3.87.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241106.0
workerd 1.20241106.1 1.20241106.1
workerd --version 1.20241106.1 2024-11-06

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@emily-shen emily-shen marked this pull request as ready for review November 14, 2024 13:14
andyjessop
andyjessop approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@andyjessop andyjessop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

packages/wrangler/src/dev.ts Outdated
positionalArgs: ["script"],
args: {
script: {
describe: "The path to an entry point for your worker",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have some inconsistency in capitalisation for Worker - I feel like we capitalise it in most places.

packages/wrangler/src/dev.ts
},
},
async validateArgs(args) {
if (args.liveReload && args.remote) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to have this outside the handler 👍

@emily-shen emily-shen merged commit d4d3062 into main Nov 15, 2024
32 checks passed
@emily-shen emily-shen deleted the emily/dev-cmd branch November 15, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyjessop andyjessop andyjessop approved these changes

Assignees
No one assigned
Labels
e2e Run e2e tests on a PR no-changeset-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emily-shen @andyjessop