Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable hyperdrive bindings in getPlatformProxy #6612

Merged
merged 3 commits into from
Sep 10, 2024
Merged

Conversation

dario-piotrowicz
Copy link
Member

@dario-piotrowicz dario-piotrowicz commented Sep 1, 2024

What this PR solves / how to test

This PR simply adds hyperdrive bindings support to Miniflare's getBindings and consequently to getPlatformProxy.

The hyperdrive proxies have overrides to make them usable within node.js, since the hyperdrive values can only work inside the workerd process itself.

Author has addressed the following

Copy link

changeset-bot bot commented Sep 1, 2024

🦋 Changeset detected

Latest commit: 2e18b6e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
wrangler Patch
miniflare Patch
@cloudflare/vitest-pool-workers Patch
@cloudflare/pages-shared Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 1, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10778596658/npm-package-wrangler-6612

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6612/npm-package-wrangler-6612

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10778596658/npm-package-wrangler-6612 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10778596658/npm-package-create-cloudflare-6612 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10778596658/npm-package-cloudflare-kv-asset-handler-6612
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10778596658/npm-package-miniflare-6612
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10778596658/npm-package-cloudflare-pages-shared-6612
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10778596658/npm-package-cloudflare-vitest-pool-workers-6612
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10778596658/npm-package-cloudflare-workers-editor-shared-6612
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10778596658/npm-package-cloudflare-workers-shared-6612

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.75.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240821.1
workerd 1.20240821.1 1.20240821.1
workerd --version 1.20240821.1 2024-08-21

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@dario-piotrowicz dario-piotrowicz changed the title fix: fix hyperdrive bindings not getting proxies by miniflare fix: fix hyperdrive bindings not getting proxied by miniflare Sep 1, 2024
@dario-piotrowicz dario-piotrowicz force-pushed the hyperdrive-gpp branch 2 times, most recently from 3cd66fe to 426c2e6 Compare September 7, 2024 17:52
@workers-devprod workers-devprod added the e2e Run e2e tests on a PR label Sep 7, 2024
@dario-piotrowicz dario-piotrowicz changed the title fix: fix hyperdrive bindings not getting proxied by miniflare enable hyperdrive bindings in getPlatformProxy Sep 7, 2024
@dario-piotrowicz dario-piotrowicz marked this pull request as ready for review September 7, 2024 17:53
@dario-piotrowicz dario-piotrowicz requested a review from a team as a code owner September 7, 2024 17:53
@dario-piotrowicz dario-piotrowicz force-pushed the hyperdrive-gpp branch 2 times, most recently from d6f92e4 to 45c6c59 Compare September 7, 2024 21:42
@dario-piotrowicz dario-piotrowicz merged commit 6471090 into main Sep 10, 2024
23 checks passed
@dario-piotrowicz dario-piotrowicz deleted the hyperdrive-gpp branch September 10, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e tests on a PR
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants