Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Define expected package manager #6119

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

CarmenPopoviciu
Copy link
Contributor

@CarmenPopoviciu CarmenPopoviciu commented Jun 21, 2024

The "packageManager" field defines which package manager is expected to be used when working on the current project. It can set to any of the supported package managers, and will ensure that your teams use the exact same package manager versions without having to install anything else than Node.js. See https://nodejs.org/dist/latest-v16.x/docs/api/all.html#all_packages_packagemanager for more information.

This commit sets the expected package manager in workers-sdk to pnpm@9.1.3. We're also secretly hoping, as per dependabot/dependabot-core#9682 (comment), that this will fix our dependabot-updater issues 😋 🤞

What this PR solves / how to test

Fixes #[insert GH or internal issue number(s)].

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because: sets package manager
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required / Maybe required
    • Not required because: sets package manager
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because: sets package manager
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Not necessary because: sets package manager

@CarmenPopoviciu CarmenPopoviciu requested a review from a team as a code owner June 21, 2024 14:12
Copy link

changeset-bot bot commented Jun 21, 2024

⚠️ No Changeset found

Latest commit: 3af9555

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

The "packageManager" field defines which package
manager is expected to be used when working on the
current project. It can set to any of the supported
package managers, and will ensure that your teams
use the exact same package manager versions without
having to install anything else than Node.js. See
https://nodejs.org/dist/latest-v16.x/docs/api/all.html#all_packages_packagemanager
for more information.

This commit sets the expected package manager in
`workers-sdk` to `pnpm@9.1.3`.
@CarmenPopoviciu CarmenPopoviciu force-pushed the carmen/one-can-only-hope-to-fix-dependabot branch from 92b0416 to 3af9555 Compare June 21, 2024 14:20
Copy link
Contributor

github-actions bot commented Jun 21, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9615141719/npm-package-wrangler-6119

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6119/npm-package-wrangler-6119

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9615141719/npm-package-wrangler-6119 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9615141719/npm-package-create-cloudflare-6119 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9615141719/npm-package-cloudflare-kv-asset-handler-6119
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9615141719/npm-package-miniflare-6119
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9615141719/npm-package-cloudflare-pages-shared-6119
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9615141719/npm-package-cloudflare-vitest-pool-workers-6119

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.61.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240610.1
workerd 1.20240610.1 1.20240610.1
workerd --version 1.20240610.1 2024-06-10

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@CarmenPopoviciu CarmenPopoviciu merged commit d7e6f11 into main Jun 21, 2024
19 checks passed
@CarmenPopoviciu CarmenPopoviciu deleted the carmen/one-can-only-hope-to-fix-dependabot branch June 21, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants