Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use the correct afterEach in deploy-non-npm-packages tests #5179

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

petebacondarwin
Copy link
Contributor

Oops!

Copy link

changeset-bot bot commented Mar 6, 2024

⚠️ No Changeset found

Latest commit: 37f4956

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@petebacondarwin petebacondarwin marked this pull request as ready for review March 6, 2024 11:51
@petebacondarwin petebacondarwin requested a review from a team as a code owner March 6, 2024 11:51
Copy link
Contributor

github-actions bot commented Mar 6, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8171579271/npm-package-wrangler-5179

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5179/npm-package-wrangler-5179

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8171579271/npm-package-wrangler-5179 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8171579271/npm-package-create-cloudflare-5179 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8171579271/npm-package-cloudflare-kv-asset-handler-5179
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8171579271/npm-package-miniflare-5179
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8171579271/npm-package-cloudflare-pages-shared-5179
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8171579271/npm-package-cloudflare-vitest-pool-workers-5179

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.31.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240223.1
workerd 1.20240304.0 1.20240304.0
workerd --version 1.20240304.0 2024-03-04

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.41%. Comparing base (d70f44a) to head (37f4956).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5179      +/-   ##
==========================================
+ Coverage   70.35%   70.41%   +0.05%     
==========================================
  Files         298      298              
  Lines       15567    15567              
  Branches     4007     4007              
==========================================
+ Hits        10952    10961       +9     
+ Misses       4615     4606       -9     

see 7 files with indirect coverage changes

@petebacondarwin petebacondarwin merged commit 24e1dca into main Mar 6, 2024
15 checks passed
@petebacondarwin petebacondarwin deleted the after-each-fix branch March 6, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants