PR feedback

cloudflare · Jan 9, 2025 · 3bd3768 · 3bd3768
1 parent a60613b
commit 3bd3768
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 5 deletions.
diff --git a/.changeset/silver-plums-brake.md b/.changeset/silver-plums-brake.md
@@ -2,4 +2,14 @@
 "wrangler": minor
 ---
 
-Add support for env files to wrangler secret bulk
+Add support for env files to wrangler secret bulk i.e. `.dev.vars`
+
+Run `wrangler secret bulk .dev.vars` to add the env file
+
+```env
+//.dev.vars
+KEY=VALUE
+KEY_2=VALUE
+```
+
+This will upload the secrets KEY and KEY_2 to your worker
diff --git a/packages/wrangler/src/__tests__/secret.test.ts b/packages/wrangler/src/__tests__/secret.test.ts
@@ -1087,7 +1087,7 @@ describe("wrangler secret", () => {
 				"wrangler secret:bulk [json]
 
 				POSITIONALS
-				  json  The file of key-value pairs to upload, as JSON in form {\\"key\\": value, ...} or .env file in the form KEY=VALUE  [string]
+				  json  The file of key-value pairs to upload, as JSON in form {\\"key\\": value, ...} or .dev.vars file in the form KEY=VALUE  [string]
 
 				GLOBAL FLAGS
 				  -c, --config   Path to Wrangler configuration file  [string]

diff --git a/packages/wrangler/src/pages/secret/index.ts b/packages/wrangler/src/pages/secret/index.ts
@@ -170,7 +170,7 @@ export const secret = (secretYargs: CommonYargsArgv, subHelp: SubHelp) => {
 			(yargs) => {
 				return yargs
 					.positional("json", {
-						describe: `The file of key-value pairs to upload, as JSON in form {"key": value, ...} or .env file in the form KEY=VALUE`,
+						describe: `The file of key-value pairs to upload, as JSON in form {"key": value, ...} or .dev.vars file in the form KEY=VALUE`,
 						type: "string",
 					})
 					.option("project-name", {

diff --git a/packages/wrangler/src/secret/index.ts b/packages/wrangler/src/secret/index.ts
@@ -378,7 +378,7 @@ export const secret = (secretYargs: CommonYargsArgv) => {
 export const secretBulkOptions = (yargs: CommonYargsArgv) => {
 	return yargs
 		.positional("json", {
-			describe: `The file of key-value pairs to upload, as JSON in form {"key": value, ...} or .env file in the form KEY=VALUE`,
+			describe: `The file of key-value pairs to upload, as JSON in form {"key": value, ...} or .dev.vars file in the form KEY=VALUE`,
 			type: "string",
 		})
 		.option("name", {

diff --git a/packages/wrangler/src/versions/secrets/bulk.ts b/packages/wrangler/src/versions/secrets/bulk.ts
@@ -20,7 +20,7 @@ export const versionsSecretBulkCommand = createCommand({
 	},
 	args: {
 		json: {
-			describe: `The file of key-value pairs to upload, as JSON in form {"key": value, ...} or .env file in the form KEY=VALUE`,
+			describe: `The file of key-value pairs to upload, as JSON in form {"key": value, ...} or .dev.vars file in the form KEY=VALUE`,
 			type: "string",
 		},
 		name: {
-Original file line number
+Diff line change
@@ Expand Up / @@ -20,7 +20,7 @@ export const versionsSecretBulkCommand = createCommand({ @@
     	},
     	args: {
     		json: {
-    			describe: `The file of key-value pairs to upload, as JSON in form {"key": value, ...} or .env file in the form KEY=VALUE`,
+    			describe: `The file of key-value pairs to upload, as JSON in form {"key": value, ...} or .dev.vars file in the form KEY=VALUE`,
     			type: "string",
     		},
     		name: {
@@ Expand Down @@